linux-kernel - Re: [PATCH 4/3] KVM: x86/xen: Make runstate cache gpcs share a lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1334123412b8cdf5bc23c81c039d1d13ca41627.camel@infradead.org>
Date:   Tue, 31 Jan 2023 16:58:41 +0000
From:   David Woodhouse <dwmw2@...radead.org>
To:     David Stevens <stevensd@...omium.org>,
        Sean Christopherson <seanjc@...gle.com>
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/3] KVM: x86/xen: Make runstate cache gpcs share a lock

(resending from non-broken system)

On Mon, 2023-01-30 at 14:25 +0900, David Stevens wrote:
> From: David Stevens <stevensd@...omium.org>
> 
> Simplify locking in the case where the guest's runstate_info is split
> across two pages by sharing a single lock for the two gpcs.
> 
> Signed-off-by: David Stevens <stevensd@...omium.org>
> ---
> I tested this patch with xen_shinfo_test as suggested, and it still
> passes. I agree that it makes sense to do this as a seperate patch. For
> the bot reported issue, looks like I forgot to build with lockdep
> enabled. I'll fix the issue with that patch in the next revision of the
> series, so that there aren't any commits which don't build.

Ack. Running actual Xen guests also works (but it's the xen_shinfo_test
which is going to exercise cross-page runstate and is most
interesting).

Tested-by: David Woodhouse <dwmw@...zon.co.uk>
Reviewed-By: David Woodhouse <dwmw@...zon.co.uk>



Download attachment "smime.p7s" of type "application/pkcs7-signature" (5965 bytes)