[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230131170606.GA3599161@roeck-us.net>
Date: Tue, 31 Jan 2023 09:06:06 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Neil Armstrong <neil.armstrong@...aro.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Kevin Hilman <khilman@...libre.com>,
Jerome Brunet <jbrunet@...libre.com>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
Wim Van Sebroeck <wim@...ux-watchdog.org>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
Thomas Gleixner <tglx@...utronix.de>,
Ulf Hansson <ulf.hansson@...aro.org>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Rob Herring <robh@...nel.org>,
Krzysztof WilczyĆski <kw@...ux.com>,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-watchdog@...r.kernel.org, linux-media@...r.kernel.org,
linux-mmc@...r.kernel.org, linux-pci@...r.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v3 3/7] dt-bindings: watchdog: convert meson-wdt.txt to
dt-schema
On Mon, Jan 23, 2023 at 11:10:00AM +0100, Neil Armstrong wrote:
> Convert the Amlogic Meson6 SoCs Watchdog timer bindings to dt-schema.
>
> Take in account the used interrupts property.
>
> The "amlogic,meson8-wdt" representation has been simplified
> since there's no users of this compatible used along the
> "amlogic,meson6-wdt".
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> ---
> .../bindings/watchdog/amlogic,meson6-wdt.yaml | 50 ++++++++++++++++++++++
> .../devicetree/bindings/watchdog/meson-wdt.txt | 21 ---------
> 2 files changed, 50 insertions(+), 21 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/amlogic,meson6-wdt.yaml b/Documentation/devicetree/bindings/watchdog/amlogic,meson6-wdt.yaml
> new file mode 100644
> index 000000000000..84732cb58ec4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/amlogic,meson6-wdt.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/amlogic,meson6-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Amlogic Meson6 SoCs Watchdog timer
> +
> +maintainers:
> + - Neil Armstrong <neil.armstrong@...aro.org>
> + - Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> +
> +allOf:
> + - $ref: watchdog.yaml#
> +
> +properties:
> + compatible:
> + oneOf:
> + - enum:
> + - amlogic,meson6-wdt
> + - amlogic,meson8-wdt
> + - amlogic,meson8b-wdt
> + - items:
> + - const: amlogic,meson8m2-wdt
> + - const: amlogic,meson8b-wdt
> +
> + interrupts:
> + maxItems: 1
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - interrupts
> + - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + wdt: watchdog@...09900 {
> + compatible = "amlogic,meson6-wdt";
> + reg = <0xc1109900 0x8>;
> + interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>;
> + timeout-sec = <10>;
> + };
> diff --git a/Documentation/devicetree/bindings/watchdog/meson-wdt.txt b/Documentation/devicetree/bindings/watchdog/meson-wdt.txt
> deleted file mode 100644
> index 7588cc3971bf..000000000000
> --- a/Documentation/devicetree/bindings/watchdog/meson-wdt.txt
> +++ /dev/null
> @@ -1,21 +0,0 @@
> -Meson SoCs Watchdog timer
> -
> -Required properties:
> -
> -- compatible : depending on the SoC this should be one of:
> - "amlogic,meson6-wdt" on Meson6 SoCs
> - "amlogic,meson8-wdt" and "amlogic,meson6-wdt" on Meson8 SoCs
> - "amlogic,meson8b-wdt" on Meson8b SoCs
> - "amlogic,meson8m2-wdt" and "amlogic,meson8b-wdt" on Meson8m2 SoCs
> -- reg : Specifies base physical address and size of the registers.
> -
> -Optional properties:
> -- timeout-sec: contains the watchdog timeout in seconds.
> -
> -Example:
> -
> -wdt: watchdog@...09900 {
> - compatible = "amlogic,meson6-wdt";
> - reg = <0xc1109900 0x8>;
> - timeout-sec = <10>;
> -};
Powered by blists - more mailing lists