[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y9iIzcz5AGjVXsNG@google.com>
Date: Tue, 31 Jan 2023 11:19:41 +0800
From: Tzung-Bi Shih <tzungbi@...nel.org>
To: Prashant Malani <pmalani@...omium.org>
Cc: linux-kernel@...r.kernel.org, chrome-platform@...ts.linux.dev,
bleung@...omium.org, heikki.krogerus@...ux.intel.com,
Daisuke Nojiri <dnojiri@...omium.org>,
"Dustin L. Howett" <dustin@...ett.net>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Guenter Roeck <groeck@...omium.org>,
"Gustavo A. R. Silva" <gustavoars@...nel.org>,
Lee Jones <lee@...nel.org>,
Tinghan Shen <tinghan.shen@...iatek.com>
Subject: Re: [PATCH 1/2] platform/chrome: cros_ec: Add VDM attention headers
On Thu, Jan 26, 2023 at 08:55:45PM +0000, Prashant Malani wrote:
> Incorporate updates to the EC headers to support the retrieval of VDM
> Attention messages from port partners. These headers are already present
> in the ChromeOS EC codebase. [1]
>
> [1] https://source.chromium.org/chromium/chromiumos/platform/ec/+/main:include/ec_commands.h
>
> Signed-off-by: Prashant Malani <pmalani@...omium.org>
With a nit:
Reviewed-by: Tzung-Bi Shih <tzungbi@...nel.org>
> diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_commands.h
> index b9c4a3964247..ec327638c6eb 100644
> --- a/include/linux/platform_data/cros_ec_commands.h
> +++ b/include/linux/platform_data/cros_ec_commands.h
> @@ -5862,6 +5862,7 @@ enum tcpc_cc_polarity {
> #define PD_STATUS_EVENT_MUX_1_SET_DONE BIT(5)
> #define PD_STATUS_EVENT_VDM_REQ_REPLY BIT(6)
> #define PD_STATUS_EVENT_VDM_REQ_FAILED BIT(7)
> +#define PD_STATUS_EVENT_VDM_ATTENTION BIT(8)
This has an extra tab if comparing with others around.
Powered by blists - more mailing lists