[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <MN2PR03MB5168884376CEE35E73739A95E7D09@MN2PR03MB5168.namprd03.prod.outlook.com>
Date: Tue, 31 Jan 2023 21:28:45 +0000
From: "Sahin, Okan" <Okan.Sahin@...log.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
CC: Lee Jones <lee@...nel.org>, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Jonathan Cameron <jic23@...nel.org>,
Lars-Peter Clausen <lars@...afoo.de>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Caleb Connolly <caleb.connolly@...aro.org>,
Marcus Folkesson <marcus.folkesson@...il.com>,
"Bolboaca, Ramona" <Ramona.Bolboaca@...log.com>,
William Breathitt Gray <william.gray@...aro.org>,
ChiYuan Huang <cy_huang@...htek.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>
Subject: RE: [PATCH v3 2/5] dt-bindings: mfd: Add ADI MAX77541/MAX77540
On Tue, 31 Jan 2023 7:44 PM
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:
>On 31/01/2023 13:02, Sahin, Okan wrote:
>>>> + regulators:
>>>> + $ref: /schemas/regulator/adi,max77541-regulator.yaml#
>>>
>>> No improvements regarding bisectability - this patch fails. If you
>>> tested this patch, you would see it.
>>>
>>> Instead of ignoring comments, either implement them or ask for clarification.
>>>
>>>
>> Sorry for misunderstanding, I checked patchset as a whole not one by one this is
>why I did not get failure after "make dt_binding_check " . Right now, I understand
>why you are saying this patch fails, but what is your suggestion? what is the
>correct order for this patchset? I sent adi,max77541-regulator.yaml in path 4/5.
>In the light of discussion, should I remove all the parts related to regulator in
>patch 2/5, then add adi,max77541-regulator.yaml and update
>adi,max77541.yaml in patch 4/5? or should I add new patch to update
>adi,max77541.yaml?
>
>Regulator binding patch should be first in the series (bindings are before usage),
>then the MFD binding should come. Your cover letter should clearly at the top
>mention the dependency. You can also mention dependency in MFD patch after --
>-, because many of us do not really read cover letters...
>
>
>Best regards,
>Krzysztof
Hi Krzysztof,
Thank you for your feedback. I tried to explain in cover letter .However, I understand that it was not clear enough. I do not want to take your time, but let me ask one thing to understand the case completely. Right now, my order is like below
[cover letter]->[mfd driver]->[mfd binding]->[regulator driver]->[regulator binding]->[adc].
Should I completely change the ordering e.g. starting with regulator ending with mfd or is it sufficient to just get the regulator binding just before the mfd bindings?
Regards,
Okan
Powered by blists - more mailing lists