linux-kernel - Re: [PATCH] libata: clean up some inconsistent indenting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 1 Feb 2023 08:45:43 +0900
From:   Damien Le Moal <damien.lemoal@...nsource.wdc.com>
To:     Sergey Shtylyov <s.shtylyov@....ru>,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] libata: clean up some inconsistent indenting

On 2023/01/31 21:33, Sergey Shtylyov wrote:
> On 1/31/23 2:26 PM, Damien Le Moal wrote:
> [...]
>>> No functional modification involved.
>>>
>>> drivers/ata/pata_serverworks.c:443 serverworks_init_one() warn: inconsistent indenting.
>>>
>>> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
>>> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3905
>>> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
>>> ---
>>>  drivers/ata/pata_serverworks.c | 7 +++----
>>>  1 file changed, 3 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/ata/pata_serverworks.c b/drivers/ata/pata_serverworks.c
>>> index c0bc4af0d196..c6bd9e95d4e8 100644
>>> --- a/drivers/ata/pata_serverworks.c
>>> +++ b/drivers/ata/pata_serverworks.c
>>> @@ -434,10 +434,9 @@ static int serverworks_init_one(struct pci_dev *pdev, const struct pci_device_id
>>>  		 (pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE) ||
>>>  		 (pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE2)) {
>>>  
>>> -		 /* If the returned btr is the newer revision then
>>> -		    select the right info block */
>>> -		 if (rc == 3)
>>> -		 	ppi[0] = &info[3];
>>> +		/* If the returned btr is the newer revision then select the right info block */
>>
>> Very long line. Please make that a proper multi-line comment.
> 
>    Perhaps the material of a separate patch?

Since this patch touches this comment, the fix should be correct from the start.
I do not see the point of having a different patch fixing a patch that was ideal
to start with...

> 
>> And the patch title should be:
>>
>> ata: pata_serverworks: clean up indentation
> 
>    Yes!
> 
> [...]
> 
> MBR, Sergey

-- 
Damien Le Moal
Western Digital Research