linux-kernel - [tip:x86/tdx 3/7] arch/x86/coco/tdx/tdcall.o: warning: objtool: __tdx_hypercall+0x7b: return with modified stack frame

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 31 Jan 2023 12:25:58 +0800
From:   kernel test robot <lkp@...el.com>
To:     "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        x86@...nel.org, Dave Hansen <dave.hansen@...ux.intel.com>
Subject: [tip:x86/tdx 3/7] arch/x86/coco/tdx/tdcall.o: warning: objtool:
 __tdx_hypercall+0x7b: return with modified stack frame

Hi Kirill,

FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/tdx
head:   8de62af018cc9262649d7688f7eb1409b2d8f594
commit: c30c4b2555ba93b845559a036293fcaf7ffd2b82 [3/7] x86/tdx: Refactor __tdx_hypercall() to allow pass down more arguments
config: x86_64-randconfig-a012-20221107 (https://download.01.org/0day-ci/archive/20230131/202301311257.jasMtEiE-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=c30c4b2555ba93b845559a036293fcaf7ffd2b82
        git remote add tip https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
        git fetch --no-tags tip x86/tdx
        git checkout c30c4b2555ba93b845559a036293fcaf7ffd2b82
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash arch/x86/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> arch/x86/coco/tdx/tdcall.o: warning: objtool: __tdx_hypercall+0x7b: return with modified stack frame


objdump-func vmlinux.o __tdx_hypercall:
0000 0000000000004c40 <__tdx_hypercall>:
0000     4c40:	55                   	push   %rbp
0001     4c41:	48 89 e5             	mov    %rsp,%rbp
0004     4c44:	41 57                	push   %r15
0006     4c46:	41 56                	push   %r14
0008     4c48:	41 55                	push   %r13
000a     4c4a:	41 54                	push   %r12
000c     4c4c:	55                   	push   %rbp
000d     4c4d:	48 89 f8             	mov    %rdi,%rax
0010     4c50:	48 89 f5             	mov    %rsi,%rbp
0013     4c53:	4c 8b 50 10          	mov    0x10(%rax),%r10
0017     4c57:	4c 8b 58 18          	mov    0x18(%rax),%r11
001b     4c5b:	4c 8b 60 20          	mov    0x20(%rax),%r12
001f     4c5f:	4c 8b 68 28          	mov    0x28(%rax),%r13
0023     4c63:	4c 8b 70 30          	mov    0x30(%rax),%r14
0027     4c67:	4c 8b 78 38          	mov    0x38(%rax),%r15
002b     4c6b:	50                   	push   %rax
002c     4c6c:	31 c0                	xor    %eax,%eax
002e     4c6e:	b9 00 fc 00 00       	mov    $0xfc00,%ecx
0033     4c73:	48 f7 c5 02 00 00 00 	test   $0x2,%rbp
003a     4c7a:	74 01                	je     4c7d <__tdx_hypercall+0x3d>
003c     4c7c:	fb                   	sti
003d     4c7d:	66 0f 01 cc          	tdcall
0041     4c81:	48 85 c0             	test   %rax,%rax
0044     4c84:	75 36                	jne    4cbc <__tdx_hypercall+0x7c>
0046     4c86:	58                   	pop    %rax
0047     4c87:	48 f7 c5 01 00 00 00 	test   $0x1,%rbp
004e     4c8e:	74 18                	je     4ca8 <__tdx_hypercall+0x68>
0050     4c90:	4c 89 50 10          	mov    %r10,0x10(%rax)
0054     4c94:	4c 89 58 18          	mov    %r11,0x18(%rax)
0058     4c98:	4c 89 60 20          	mov    %r12,0x20(%rax)
005c     4c9c:	4c 89 68 28          	mov    %r13,0x28(%rax)
0060     4ca0:	4c 89 70 30          	mov    %r14,0x30(%rax)
0064     4ca4:	4c 89 78 38          	mov    %r15,0x38(%rax)
0068     4ca8:	4c 89 d0             	mov    %r10,%rax
006b     4cab:	45 31 d2             	xor    %r10d,%r10d
006e     4cae:	45 31 db             	xor    %r11d,%r11d
0071     4cb1:	5d                   	pop    %rbp
0072     4cb2:	41 5c                	pop    %r12
0074     4cb4:	41 5d                	pop    %r13
0076     4cb6:	41 5e                	pop    %r14
0078     4cb8:	41 5f                	pop    %r15
007a     4cba:	5d                   	pop    %rbp
007b     4cbb:	c3                   	ret
007c     4cbc:	e8 00 00 00 00       	call   4cc1 <__tdx_hypercall+0x81>	4cbd: R_X86_64_PLT32	__tdx_hypercall_failed-0x4
0081     4cc1:	eb f9                	jmp    4cbc <__tdx_hypercall+0x7c>
0083     4cc3:	66 2e 0f 1f 84 00 00 00 00 00 	cs nopw 0x0(%rax,%rax,1)
008d     4ccd:	66 2e 0f 1f 84 00 00 00 00 00 	cs nopw 0x0(%rax,%rax,1)
0097     4cd7:	66 2e 0f 1f 84 00 00 00 00 00 	cs nopw 0x0(%rax,%rax,1)
00a1     4ce1:	66 2e 0f 1f 84 00 00 00 00 00 	cs nopw 0x0(%rax,%rax,1)
00ab     4ceb:	66 2e 0f 1f 84 00 00 00 00 00 	cs nopw 0x0(%rax,%rax,1)
00b5     4cf5:	66 2e 0f 1f 84 00 00 00 00 00 	cs nopw 0x0(%rax,%rax,1)
00bf     4cff:	90                   	nop

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests