linux-kernel - RE: [PATCH] arm64: dts: imx8mq: update usb compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DU0PR04MB941741A921F3953E165BB45F88D09@DU0PR04MB9417.eurprd04.prod.outlook.com>
Date:   Tue, 31 Jan 2023 09:34:49 +0000
From:   Peng Fan <peng.fan@....com>
To:     Marco Felsch <m.felsch@...gutronix.de>,
        "Peng Fan (OSS)" <peng.fan@....nxp.com>
CC:     "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        dl-linux-imx <linux-imx@....com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH] arm64: dts: imx8mq: update usb compatible string

> Subject: Re: [PATCH] arm64: dts: imx8mq: update usb compatible string
> 
> Hi,
> 
> On 23-01-31, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@....com>
> >
> > There is no fsl,imx8mq-dwc3 binding doc, no driver use this compatible
> > string. Drop it.
> 
> please don't. I'm not aware of the driver state but the compatibles are there
> for _possible_ quirk handling, so the driver can add a match on demand.

NXP downstream also not has driver use this compatible string, and pass
several GA releases.

People could add it back when it is needed together with binding doc.

Thanks,
Peng.

> 
> Regards,
>   Marco
> 
> 
> >
> > Signed-off-by: Peng Fan <peng.fan@....com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > index d59156fdee0b..d308f94a7c52 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > @@ -1431,7 +1431,7 @@ gpu: gpu@...00000 {
> >  		};
> >
> >  		usb_dwc3_0: usb@...00000 {
> > -			compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
> > +			compatible = "snps,dwc3";
> >  			reg = <0x38100000 0x10000>;
> >  			clocks = <&clk IMX8MQ_CLK_USB1_CTRL_ROOT>,
> >  			         <&clk IMX8MQ_CLK_USB_CORE_REF>, @@ -
> 1463,7 +1463,7 @@
> > usb3_phy0: usb-phy@...f0040 {
> >  		};
> >
> >  		usb_dwc3_1: usb@...00000 {
> > -			compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
> > +			compatible = "snps,dwc3";
> >  			reg = <0x38200000 0x10000>;
> >  			clocks = <&clk IMX8MQ_CLK_USB2_CTRL_ROOT>,
> >  			         <&clk IMX8MQ_CLK_USB_CORE_REF>,
> > --
> > 2.37.1
> >
> >
> >