linux-kernel - Re: [PATCH] tty:pty: move wake_up*() after tty_vhangup() in pty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y9jlzjbEGMe/KM55@kroah.com>
Date:   Tue, 31 Jan 2023 10:56:30 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Yan Cangang <nalanzeyu@...il.com>
Cc:     jirislaby@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty:pty: move wake_up*() after tty_vhangup() in
 pty_close()

On Fri, Jan 27, 2023 at 03:20:17PM +0800, Yan Cangang wrote:
> wake_up_interruptible() may wake up the session leader blocked on pts, at
> this time the tty_signal_session_leader() in __tty_hangup() has not been
> executed.
> 
> The session leader's subsequent IO on pts will fail, but the session
> leader did not received SIGHUP as expected at this time.
> 
> A observed phenomenon is that when the ssh connection is disconnected, the
> background jobs managed by bash did not terminate as expected. This
> problem is more easily observed on low-end single-processor systems.

This feels odd, why is this only showing up now?  What changed to cause
this issue?

What commit id does this fix?

thanks,

greg k-h