linux-kernel - Re: [PATCH v2 00/11] fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 31 Jan 2023 10:18:13 +0000
From:   Sudeep Holla <sudeep.holla@....com>
To:     Saravana Kannan <saravanak@...gle.com>
Cc:     Naresh Kamboju <naresh.kamboju@...aro.org>, abel.vesa@...aro.org,
        Sudeep Holla <sudeep.holla@....com>,
        alexander.stein@...tq-group.com, andriy.shevchenko@...ux.intel.com,
        bigunclemax@...il.com, brgl@...ev.pl,
        colin.foster@...advantage.com, cristian.marussi@....com,
        devicetree@...r.kernel.org, dianders@...omium.org,
        djrscally@...il.com, dmitry.baryshkov@...aro.org,
        festevam@...il.com, fido_max@...ox.ru, frowand.list@...il.com,
        geert+renesas@...der.be, geert@...ux-m68k.org,
        gregkh@...uxfoundation.org, heikki.krogerus@...ux.intel.com,
        jpb@...nel.org, jstultz@...gle.com, kernel-team@...roid.com,
        kernel@...gutronix.de, lenb@...nel.org, linus.walleij@...aro.org,
        linux-acpi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-gpio@...r.kernel.org, linux-imx@....com,
        linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux@...ck-us.net, lkft@...aro.org, luca.weiss@...rphone.com,
        magnus.damm@...il.com, martin.kepplinger@...i.sm, maz@...nel.org,
        miquel.raynal@...tlin.com, rafael@...nel.org, robh+dt@...nel.org,
        s.hauer@...gutronix.de, sakari.ailus@...ux.intel.com,
        shawnguo@...nel.org, tglx@...utronix.de, tony@...mide.com
Subject: Re: [PATCH v2 00/11] fw_devlink improvements

Hi Saravana,

On Mon, Jan 30, 2023 at 03:03:01PM -0800, Saravana Kannan wrote:
> On Mon, Jan 30, 2023 at 12:56 AM Naresh Kamboju
> <naresh.kamboju@...aro.org> wrote:
> >
> > Build test pass on arm, arm64, i386, mips, parisc, powerpc, riscv, s390, sh,
> > sparc and x86_64.
> >
> > Boot and LTP smoke pass on qemu-arm64, qemu-armv7, qemu-i386 and qemu-x86_64.
> > Boot failed on FVP.
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
> >
> > Please refer following link for details of testing.
> > FVP boot log failed.
> > https://qa-reports.linaro.org/~anders.roxell/linux-mainline-patches/build/lore_kernel_org_linux-devicetree_20230127001141_407071-1-saravanak_google_com/testrun/14389034/suite/boot/test/gcc-12-lkftconfig-64k_page_size/details/
>
> Sudeep pointed me to what the issue might be. But it's strange that
> you are hitting an issue now. I'm pretty sure I haven't changed this
> part since v1. I'd also expect the limited assumptions I made to have
> not been affected between v1 and v2.
>

Sorry I hadn't seen or tested v1.

FYI The fwnode non-NULL check as in your nvmem diff/suggestion and the diff I
replied on the gpiolib patch thread fixes the issues.

> Anyway, I'll look at this and fix it in v3.
>

If you add that fwnode check, feel free to add my tested by.

--
Regards,
Sudeep