linux-kernel - Re: [PATCH 3/3] gpio: mmio: Use new flag BGPIOF_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <494ca890-098d-1ba8-321b-b6378546835d@ncr.com>
Date:   Tue, 31 Jan 2023 10:23:37 +0000
From:   "Leonard, Niall" <Niall.Leonard@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
CC:     "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] gpio: mmio: Use new flag BGPIOF_NO_INPUT

On 29/01/2023 16:01, Krzysztof Kozlowski wrote:
> *External Message* - Use caution before opening links or attachments
> 
> On 26/01/2023 11:17, Niall Leonard via B4 Submission Endpoint wrote:
>> From: Niall Leonard <nl250060@....com>
>>
>> Use the existing shadow data register 'bgpio_data' to allow
>> the last written value to be returned by the read operation
>> when BGPIOF_NO_INPUT flag is set.
>>
> 
> (...)
> 
>>   	if (gc->set == bgpio_set_set &&
>>   			!(flags & BGPIOF_UNREADABLE_REG_SET))
>>   		gc->bgpio_data = gc->read_reg(gc->reg_set);
>> @@ -711,6 +723,9 @@ static struct bgpio_pdata *bgpio_parse_dt(struct platform_device *pdev,
>>   	if (of_property_read_bool(pdev->dev.of_node, "no-output"))
>>   		*flags |= BGPIOF_NO_OUTPUT;
>>   
>> +	if (of_property_read_bool(pdev->dev.of_node, "no-input"))
> 
> As pointed, this brings undocumented property to two other bindings.
> This needs to be fixed.
> 
> Best regards,
> Krzysztof
> 
Thanks for reviewing.
I will update the other 2 bindings in the next version.

Regards,
Niall Leonard