[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y9juvficPxFUfgHD@Red>
Date: Tue, 31 Jan 2023 11:34:37 +0100
From: Corentin LABBE <clabbe@...libre.com>
To: troy.lin@...k-chips.com, shawn.lin@...k-chips.com,
hl@...k-chips.com, ty@...s.org, mike.rudenko@...il.com
Cc: "Jason A. Donenfeld" <Jason@...c4.com>,
linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
Herbert Xu <herbert@...dor.apana.org.au>,
Heiko Stuebner <heiko@...ech.de>,
linux-rockchip@...ts.infradead.org, robin.murphy@....com
Subject: Re: [PATCH] hw_random: rockchip: import driver from vendor tree
Le Tue, Sep 20, 2022 at 10:35:44AM +0100, Robin Murphy a écrit :
> On 2022-09-19 22:00, Jason A. Donenfeld wrote:
> > The Rockchip driver has long existed out of tree, but not upstream.
> > There is support for it upstream in u-boot, but not in Linux proper.
> > This commit imports the GPLv2 driver written by Lin Jinhan, together
> > with the DTS and config blobs from Wevsty.
>
> Note that Corentin has a series enabling the full crypto driver for
> RK3328 and RK3399[1], so it would seem more sensible to add TRNG support
> to that. Having confliciting compatibles for the same hardware that
> force the user to change their DT to choose one functionality or the
> other isn't good (plus there's also no binding for this one).
>
> Robin.
>
Hello
I am very interested on how this serie was tested and which tools was used to ensure output was random.
And how did you get that CRYPTO_V1_TRNG_SAMPLE_PERIOD(100); was the best choice.
Thanks
Regards
Powered by blists - more mailing lists