linux-kernel - Re: [PATCH resend] compiler-intel: Remove duplicate RELOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 31 Jan 2023 11:41:08 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Geert Uytterhoeven" <geert+renesas@...der.be>,
        "Masahiro Yamada" <masahiroy@...nel.org>,
        "Andrew Morton" <akpm@...ux-foundation.org>,
        "H. Peter Anvin" <hpa@...or.com>
Cc:     linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH resend] compiler-intel: Remove duplicate RELOC_HIDE()

On Tue, Jan 31, 2023, at 11:37, Geert Uytterhoeven wrote:
> The RELOC_HIDE() implementation for the Intel compiler is identical to
> the generic version in <linux/compiler.h>, so the former can just be
> removed.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> Not even compile-tested.
> ---
>  include/linux/compiler-intel.h | 5 -----
>  1 file changed, 5 deletions(-)

I thought the entire file was gone already. I don't see anyone
objecting to the earlier patch

https://lore.kernel.org/all/20221016182349.49308-1-masahiroy@kernel.org/

but it never made it in. Maybe we can revive that instead?

Otherwise, your patch looks obviously correct as well.

Acked-by: Arnd Bergmann <arnd@...db.de>