[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Y9kEP+ozg8eyYLbS@matsya>
Date: Tue, 31 Jan 2023 17:36:23 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc: yung-chuan.liao@...ux.intel.com,
pierre-louis.bossart@...ux.intel.com, sanyog.r.kale@...el.com,
alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
patches@...nsource.cirrus.com
Subject: Re: [PATCH v2 0/2] soundwire: Remove redundant zeroing of page
registers
On 23-01-23, 16:49, Richard Fitzgerald wrote:
> Writing zero to the page registers after each message transaction can add
> up to a lot of overhead for codecs that need to transfer large amount of
> data - for example a firmware download.
>
> There's no spec reason I can see for this zeroing. The page registers are
> only used for a paged address. The bus code uses a non-paged address for
> registers in page 0. It always writes the page registers at the start of
> a paged transaction.
>
> If this zeroing was a workaround for anything, let me know and I will
> re-implement the zeroing as a quirk that can be enabled only when it is
> necessary.
Applied, thanks
--
~Vinod
Powered by blists - more mailing lists