linux-kernel - Re: [PATCH] media: rc: add keymap for Beelink Mini MXIII remote

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y9kJfPqtd98wIQ6r@gofer.mess.org>
Date:   Tue, 31 Jan 2023 12:28:44 +0000
From:   Sean Young <sean@...s.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Christian Hewitt <christianshewitt@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH] media: rc: add keymap for Beelink Mini MXIII remote

On Mon, Jan 30, 2023 at 03:30:20PM -0600, Rob Herring wrote:
> On Sun, Jan 29, 2023 at 08:38:06AM +0000, Sean Young wrote:
> > On Sat, Jan 28, 2023 at 11:11:32AM +0100, Krzysztof Kozlowski wrote:
> > > On 28/01/2023 04:41, Christian Hewitt wrote:
> > > > Add a keymap and bindings for the simple IR (NEC) remote used with
> > > > the Beelink Mini MXIII Android STB device.
> > > > 
> > > > Signed-off-by: Christian Hewitt <christianshewitt@...il.com>
> > > > ---
> > > >  .../devicetree/bindings/media/rc.yaml         |  1 +
> > > >  drivers/media/rc/keymaps/Makefile             |  1 +
> > > >  drivers/media/rc/keymaps/rc-beelink-mxiii.c   | 54 +++++++++++++++++++
> > > >  include/media/rc-map.h                        |  1 +
> > > >  4 files changed, 57 insertions(+)
> > > >  create mode 100644 drivers/media/rc/keymaps/rc-beelink-mxiii.c
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/media/rc.yaml b/Documentation/devicetree/bindings/media/rc.yaml
> > > > index 266f1d5cae51..f390a5d2c82d 100644
> > > > --- a/Documentation/devicetree/bindings/media/rc.yaml
> > > > +++ b/Documentation/devicetree/bindings/media/rc.yaml
> > > > @@ -39,6 +39,7 @@ properties:
> > > >        - rc-avertv-303
> > > >        - rc-azurewave-ad-tu700
> > > >        - rc-beelink-gs1
> > > > +      - rc-beelink-mxiii
> > > 
> > > Bindings are separate patches. Didn't you get such feedback already?
> > 
> > The only change for new keymaps is an added entry to the rc-map-name enum.
> > In the past, new keymaps have been accepted with that single line in the
> > same commit.
> 
> It's been a checkpatch.pl warning since 2018. The separation is so that 
> commit messages in the DT only repo[1] make sense.

Ok, makes sense. 

Thanks,

Sean