linux-kernel - Re: [PATCH] kunit: fix kunit_test_init_section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKgze5YQnQUPZFpy2h_CObB8zhwmKzGFUQ7tnC3_LqNZVW+-+A@mail.gmail.com>
Date:   Tue, 31 Jan 2023 10:27:02 -0300
From:   Martin Fernandez <martin.fernandez@...ypsium.com>
To:     David Gow <davidgow@...gle.com>
Cc:     Brendan Higgins <brendan.higgins@...ux.dev>,
        Daniel Latypov <dlatypov@...gle.com>,
        Shuah Khan <skhan@...uxfoundation.org>,
        Rae Moar <rmoar@...gle.com>, kunit-dev@...glegroups.com,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kunit: fix kunit_test_init_section_suites(...)

On 1/30/23, David Gow <davidgow@...gle.com> wrote:
> From: Brendan Higgins <brendan.higgins@...ux.dev>
>
> Looks like kunit_test_init_section_suites(...) was messed up in a merge
> conflict. This fixes it.
>
> kunit_test_init_section_suites(...) was not updated to avoid the extra
> level of indirection when .kunit_test_suites was flattened. Given no-one
> was actively using it, this went unnoticed for a long period of time.
>
> Fixes: e5857d396f35 ("kunit: flatten kunit_suite*** to kunit_suite** in
> .kunit_test_suites")
> Signed-off-by: Brendan Higgins <brendan.higgins@...ux.dev>
> Signed-off-by: David Gow <davidgow@...gle.com>
> ---
>  include/kunit/test.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/include/kunit/test.h b/include/kunit/test.h
> index 87ea90576b50..716deaeef3dd 100644
> --- a/include/kunit/test.h
> +++ b/include/kunit/test.h
> @@ -303,7 +303,6 @@ static inline int kunit_run_all_tests(void)
>   */
>  #define kunit_test_init_section_suites(__suites...)			\
>  	__kunit_test_suites(CONCATENATE(__UNIQUE_ID(array), _probe),	\
> -			    CONCATENATE(__UNIQUE_ID(suites), _probe),	\
>  			    ##__suites)
>
>  #define kunit_test_init_section_suite(suite)	\
> --
> 2.39.1.456.gfc5497dd1b-goog
>
>

Tested-by: Martin Fernandez <martin.fernandez@...ypsium.com>

Thanks!