[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <64702a9b-6c78-3065-8335-28d31c6fc1ab@gmail.com>
Date: Tue, 31 Jan 2023 14:40:20 +0100
From: Matthias Brugger <matthias.bgg@...il.com>
To: Roger Lu <roger.lu@...iatek.com>,
Enric Balletbo Serra <eballetbo@...il.com>,
Kevin Hilman <khilman@...nel.org>,
Nicolas Boichat <drinkcat@...gle.com>
Cc: Fan Chen <fan.chen@...iatek.com>,
Jia-wei Chang <jia-wei.chang@...iatek.com>,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-pm@...r.kernel.org,
Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH v4 13/14] soc: mediatek: mtk-svs: use common function to
disable restore voltages
On 11/01/2023 08:45, Roger Lu wrote:
> The timing of disabling SVS bank and restore default voltage is more
> than one place. Therefore, add a common function to use for removing
> the superfluous codes.
>
> Signed-off-by: Roger Lu <roger.lu@...iatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Same here, change looks good. Could you please rebase and resend:
Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>
> ---
> drivers/soc/mediatek/mtk-svs.c | 54 ++++++++++++++--------------------
> 1 file changed, 22 insertions(+), 32 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
> index a7f0a6f02d52..89117807e85d 100644
> --- a/drivers/soc/mediatek/mtk-svs.c
> +++ b/drivers/soc/mediatek/mtk-svs.c
> @@ -648,6 +648,25 @@ static int svs_adjust_pm_opp_volts(struct svs_bank *svsb)
> return ret;
> }
>
> +static void svs_bank_disable_and_restore_default_volts(struct svs_platform *svsp,
> + struct svs_bank *svsb)
> +{
> + unsigned long flags;
> +
> + if (svsb->mode_support == SVSB_MODE_ALL_DISABLE)
> + return;
> +
> + spin_lock_irqsave(&svs_lock, flags);
> + svsp->pbank = svsb;
> + svs_switch_bank(svsp);
> + svs_writel_relaxed(svsp, SVSB_PTPEN_OFF, SVSEN);
> + svs_writel_relaxed(svsp, SVSB_INTSTS_VAL_CLEAN, INTSTS);
> + spin_unlock_irqrestore(&svs_lock, flags);
> +
> + svsb->phase = SVSB_PHASE_ERROR;
> + svs_adjust_pm_opp_volts(svsb);
> +}
> +
> #ifdef CONFIG_DEBUG_FS
> static int svs_dump_debug_show(struct seq_file *m, void *p)
> {
> @@ -724,7 +743,6 @@ static ssize_t svs_enable_debug_write(struct file *filp,
> {
> struct svs_bank *svsb = file_inode(filp)->i_private;
> struct svs_platform *svsp = dev_get_drvdata(svsb->dev);
> - unsigned long flags;
> int enabled, ret;
> char *buf = NULL;
>
> @@ -740,16 +758,8 @@ static ssize_t svs_enable_debug_write(struct file *filp,
> return ret;
>
> if (!enabled) {
> - spin_lock_irqsave(&svs_lock, flags);
> - svsp->pbank = svsb;
> + svs_bank_disable_and_restore_default_volts(svsp, svsb);
> svsb->mode_support = SVSB_MODE_ALL_DISABLE;
> - svs_switch_bank(svsp);
> - svs_writel_relaxed(svsp, SVSB_PTPEN_OFF, SVSEN);
> - svs_writel_relaxed(svsp, SVSB_INTSTS_VAL_CLEAN, INTSTS);
> - spin_unlock_irqrestore(&svs_lock, flags);
> -
> - svsb->phase = SVSB_PHASE_ERROR;
> - svs_adjust_pm_opp_volts(svsb);
> }
>
> kfree(buf);
> @@ -1532,16 +1542,7 @@ static int svs_init02(struct svs_platform *svsp)
> out_of_init02:
> for (idx = 0; idx < svsp->bank_max; idx++) {
> svsb = &svsp->banks[idx];
> -
> - spin_lock_irqsave(&svs_lock, flags);
> - svsp->pbank = svsb;
> - svs_switch_bank(svsp);
> - svs_writel_relaxed(svsp, SVSB_PTPEN_OFF, SVSEN);
> - svs_writel_relaxed(svsp, SVSB_INTSTS_VAL_CLEAN, INTSTS);
> - spin_unlock_irqrestore(&svs_lock, flags);
> -
> - svsb->phase = SVSB_PHASE_ERROR;
> - svs_adjust_pm_opp_volts(svsb);
> + svs_bank_disable_and_restore_default_volts(svsp, svsb);
> }
>
> return ret;
> @@ -1587,7 +1588,6 @@ static int svs_suspend(struct device *dev)
> {
> struct svs_platform *svsp = dev_get_drvdata(dev);
> struct svs_bank *svsb;
> - unsigned long flags;
> int ret;
> u32 idx;
>
> @@ -1599,17 +1599,7 @@ static int svs_suspend(struct device *dev)
>
> for (idx = 0; idx < svsp->bank_max; idx++) {
> svsb = &svsp->banks[idx];
> -
> - /* This might wait for svs_isr() process */
> - spin_lock_irqsave(&svs_lock, flags);
> - svsp->pbank = svsb;
> - svs_switch_bank(svsp);
> - svs_writel_relaxed(svsp, SVSB_PTPEN_OFF, SVSEN);
> - svs_writel_relaxed(svsp, SVSB_INTSTS_VAL_CLEAN, INTSTS);
> - spin_unlock_irqrestore(&svs_lock, flags);
> -
> - svsb->phase = SVSB_PHASE_ERROR;
> - svs_adjust_pm_opp_volts(svsb);
> + svs_bank_disable_and_restore_default_volts(svsp, svsb);
> }
>
> ret = reset_control_assert(svsp->rst);
Powered by blists - more mailing lists