linux-kernel - Re: [PATCH] mm/mmap: Fix vma_merge() offset when expanding the next vma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72dfedd2-a26a-17f4-87c2-3d71ab3f55b4@redhat.com>
Date:   Tue, 31 Jan 2023 15:29:59 +0100
From:   David Hildenbrand <david@...hat.com>
To:     "Liam R. Howlett" <Liam.Howlett@...cle.com>,
        maple-tree@...ts.infradead.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-next@...r.kernel.org,
        Sanan Hasanov <sanan.hasanov@...ghts.ucf.edu>,
        Matthew Wilcox <willy@...radead.org>,
        Hugh Dickins <hughd@...gle.com>
Subject: Re: [PATCH] mm/mmap: Fix vma_merge() offset when expanding the next
 vma

On 31.01.23 15:24, Liam R. Howlett wrote:
> * David Hildenbrand <david@...hat.com> [230131 03:35]:
>> On 30.01.23 20:57, Liam R. Howlett wrote:
>>> The vm_pgoff was being set incorrectly when expanding the next VMA to a
>>> lower address.  Fix the issue by using the mid->vm_pgoff value for this
>>> merge case (aka case 8).  Note that this does not change case 3's
>>> vm_pgoff as next and mid are the same VMA.
>>>
>>> Reported-by: Sanan Hasanov <sanan.hasanov@...ghts.ucf.edu>
>>> Link: https://lore.kernel.org/linux-mm/IA1PR07MB983017D2FBA174D2FF78CEB6ABCE9@IA1PR07MB9830.namprd07.prod.outlook.com/
>>> Cc: Matthew Wilcox <willy@...radead.org>
>>> Cc: David Hildenbrand <david@...hat.com>
>>> Cc: Hugh Dickins <hughd@...gle.com>
>>
>> Fixes: ?
> 
> Fixes: (soon to be invalid git id :) ("mm/mmap: remove __vma_adjust()")

Ah, right, upstream was not affected ... :)

... so this should be squashed into that commit instead as long as it 
doesn't have a stable ID.

-- 
Thanks,

David / dhildenb