linux-kernel - Re: [RFC PATCH v6 5/6] KVM: x86: add vCPU scoped toggling for disabled exits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 31 Jan 2023 10:23:04 +0800
From:   Chao Gao <chao.gao@...el.com>
To:     Kechen Lu <kechenl@...dia.com>
CC:     "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "seanjc@...gle.com" <seanjc@...gle.com>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "zhi.wang.linux@...il.com" <zhi.wang.linux@...il.com>,
        "shaoqin.huang@...el.com" <shaoqin.huang@...el.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH v6 5/6] KVM: x86: add vCPU scoped toggling for
 disabled exits

On Mon, Jan 30, 2023 at 08:57:16PM +0000, Kechen Lu wrote:
>> On Sat, Jan 21, 2023 at 02:07:37AM +0000, Kechen Lu wrote:
>> >+static void svm_update_disabled_exits(struct kvm_vcpu *vcpu)
>> 
>> Is it possible to call this function on vCPU creation, i.e., consolidate
>> initialization and runtime toggling?
>> 
>
>Chao, can you elaborate on this? If I understand correctly, 
>you mean replacing the current redundant code on vCPU creation 
>for checking the xxx_in_guest and set intercept, while instead, calling this 
>svm/vmx_update_disabled_exits()?

That's exactly what I mean.
 
>Yeah, I think this makes sense to
>me.