linux-kernel - Re: [PATCH] driver core: bus: move lock_class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 1 Feb 2023 20:03:08 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] driver core: bus: move lock_class_key into dynamic
 structure

On Wed, Feb 01, 2023 at 07:59:42PM +0100, Rafael J. Wysocki wrote:
> On Wed, Feb 1, 2023 at 9:33 AM Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> >
> > Move the lock_class_key structure out of struct bus_type and into the
> > dynamic structure we create already for all bus_types registered with
> > the kernel.  This saves on static space and removes one more writable
> > field in struct bus_type.
> >
> > In the future, the same field can be moved out of the struct class logic
> > because it shares this same private structure.
> >
> > Most everyone will never notice this change, as lockdep is not enabled
> > in real systems so no memory or logic changes are happening for them.
> >
> > Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> This looks reasonable to me, so
> 
> Acked-by: Rafael J. Wysocki <rafael@...nel.org>

Thanks for the review.