[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y9ryWROdCrKYWBzY@google.com>
Date: Wed, 1 Feb 2023 15:14:33 -0800
From: Nick Desaulniers <ndesaulniers@...gle.com>
To: Tom Rix <trix@...hat.com>
Cc: jack@...e.com, nathan@...nel.org, linux-kernel@...r.kernel.org,
llvm@...ts.linux.dev
Subject: Re: [PATCH] udf: remove reporting loc in debug output
On Fri, Jan 27, 2023 at 08:29:06AM -0800, Tom Rix wrote:
> clang build fails with
> fs/udf/partition.c:86:28: error: variable 'loc' is uninitialized when used here [-Werror,-Wuninitialized]
> sb, block, partition, loc, index);
> ^~~
>
> loc is now only know when bh is valid. So remove reporting loc in debug output.
typo: s/know/known/
>
> Fixes: 4215db46d538 ("udf: Use udf_bread() in udf_get_pblock_virt15()")
> Signed-off-by: Tom Rix <trix@...hat.com>
Thanks Tom, kernelci has also been reporting this.
https://lore.kernel.org/linux-next/?q=error%3A+variable+%27loc%27+is+uninitialized+when+used+here
Reported-by: "kernelci.org bot" <bot@...nelci.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>
> ---
> fs/udf/partition.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/udf/partition.c b/fs/udf/partition.c
> index 92765d2f6958..5bcfe78d5cab 100644
> --- a/fs/udf/partition.c
> +++ b/fs/udf/partition.c
> @@ -82,8 +82,8 @@ uint32_t udf_get_pblock_virt15(struct super_block *sb, uint32_t block,
>
> bh = udf_bread(sbi->s_vat_inode, newblock, 0, &err);
> if (!bh) {
> - udf_debug("get_pblock(UDF_VIRTUAL_MAP:%p,%u,%u) VAT: %u[%u]\n",
> - sb, block, partition, loc, index);
> + udf_debug("get_pblock(UDF_VIRTUAL_MAP:%p,%u,%u)\n",
> + sb, block, partition);
> return 0xFFFFFFFF;
> }
>
> --
> 2.26.3
>
>
Powered by blists - more mailing lists