linux-kernel - Re: [PATCH 05/12] cifs: Add a function to Hash the contents of an iterator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y9ooW52m0Afnhj7Z@gondor.apana.org.au>
Date:   Wed, 1 Feb 2023 16:52:43 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     David Howells <dhowells@...hat.com>
Cc:     smfrench@...il.com, dhowells@...hat.com, viro@...iv.linux.org.uk,
        nspmangalore@...il.com, rohiths.msft@...il.com, tom@...pey.com,
        metze@...ba.org, hch@...radead.org, willy@...radead.org,
        jlayton@...nel.org, linux-cifs@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        sfrench@...ba.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH 05/12] cifs: Add a function to Hash the contents of an
 iterator

David Howells <dhowells@...hat.com> wrote:
> Add a function to push the contents of a BVEC-, KVEC- or XARRAY-type
> iterator into a symmetric hash algorithm.

There is no such thing as a symmetric hash.  You're using shash
which stands for synchronous hash.

In any case, as I said in the previous review this is abusing the
shash API.  Please use ahash instead.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt