[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230201112631.mgwuboehrwdefqnd@SoMainline.org>
Date: Wed, 1 Feb 2023 12:26:31 +0100
From: Marijn Suijten <marijn.suijten@...ainline.org>
To: Kalyan Thota <quic_kalyant@...cinc.com>
Cc: dri-devel@...ts.freedesktop.org, linux-arm-msm@...r.kernel.org,
freedreno@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, robdclark@...omium.org,
dianders@...omium.org, swboyd@...omium.org,
quic_vpolimer@...cinc.com, dmitry.baryshkov@...aro.org,
quic_abhinavk@...cinc.com
Subject: Re: [v1 2/3] drm/msm/disp/dpu1: add dspps into reservation if there
is a ctm request
On 2023-02-01 12:16:05, Marijn Suijten wrote:
<snip>
> > + if (dpu_kms->catalog->dspp &&
> > + crtc_state->ctm && (dpu_kms->catalog->dspp_count >= topology.num_lm))
>
> Multiline-if-clause is typically indented with two tabs, not a half tab
> (4 spaces).
Hmm, Dmitry requested indent-to-opening-parenthesis in v1 instead; and
the majority of dpu1 uses the worst version of all: indent with a single
tab so that the contents line up with the code block below. Dmitry,
I'll leave final say to you (and fix it up in my own DPU series
accordingly too).
- Marijn
Powered by blists - more mailing lists