lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAJuCfpF-Lu2fX6azVzmpJn75qDgwjpWjKT85=CEbwo2YAnx-Qw@mail.gmail.com> Date: Tue, 31 Jan 2023 16:03:49 -0800 From: Suren Baghdasaryan <surenb@...gle.com> To: Andrew Morton <akpm@...ux-foundation.org> Cc: Hyeonggon Yoo <42.hyeyoo@...il.com>, michel@...pinasse.org, jglisse@...gle.com, mhocko@...e.com, vbabka@...e.cz, hannes@...xchg.org, mgorman@...hsingularity.net, dave@...olabs.net, willy@...radead.org, liam.howlett@...cle.com, peterz@...radead.org, ldufour@...ux.ibm.com, paulmck@...nel.org, mingo@...hat.com, will@...nel.org, luto@...nel.org, songliubraving@...com, peterx@...hat.com, david@...hat.com, dhowells@...hat.com, hughd@...gle.com, bigeasy@...utronix.de, kent.overstreet@...ux.dev, punit.agrawal@...edance.com, lstoakes@...il.com, peterjung1337@...il.com, rientjes@...gle.com, axelrasmussen@...gle.com, joelaf@...gle.com, minchan@...gle.com, rppt@...nel.org, jannh@...gle.com, shakeelb@...gle.com, tatashin@...gle.com, edumazet@...gle.com, gthelen@...gle.com, gurua@...gle.com, arjunroy@...gle.com, soheil@...gle.com, leewalsh@...gle.com, posk@...gle.com, linux-mm@...ck.org, linux-arm-kernel@...ts.infradead.org, linuxppc-dev@...ts.ozlabs.org, x86@...nel.org, linux-kernel@...r.kernel.org, kernel-team@...roid.com, Sebastian Reichel <sebastian.reichel@...labora.com> Subject: Re: [PATCH v4 4/7] mm: replace vma->vm_flags direct modifications with modifier calls On Tue, Jan 31, 2023 at 3:12 PM Andrew Morton <akpm@...ux-foundation.org> wrote: > > On Tue, 31 Jan 2023 13:08:19 -0800 Suren Baghdasaryan <surenb@...gle.com> wrote: > > > On Tue, Jan 31, 2023 at 12:54 PM Andrew Morton > > <akpm@...ux-foundation.org> wrote: > > > > > > On Tue, 31 Jan 2023 10:54:22 -0800 Suren Baghdasaryan <surenb@...gle.com> wrote: > > > > > > > > > - vma->vm_flags &= ~VM_MAYWRITE; > > > > > > + vm_flags_clear(vma, VM_MAYSHARE); > > > > > > } > > > > > > > > > > I think it should be: > > > > > s/VM_MAYSHARE/VM_MAYWRITE/ > > > > > > > > > > I added the fixup. Much better than resending a seven patch series for a > > > single line change. Unless you have substantial other changes pending. > > > > Thanks! That sounds reasonable. > > > > I'll also need to introduce vm_flags_reset_once() to use in > > replacement of WRITE_ONCE(vma->vm_flags, newflags) case. Should I send > > a separate short patch for that? > > That depends on what the patch looks like. How about you send it > and we'll see? Here it is: https://lore.kernel.org/all/20230201000116.1333160-1-surenb@google.com/ > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@...roid.com. >
Powered by blists - more mailing lists