linux-kernel - Re: [PATCH v2 5/6] dt-bindings: hypervisor: Add dt-bindings for VMBus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230201015723.GB20379@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Date:   Tue, 31 Jan 2023 17:57:23 -0800
From:   Saurabh Singh Sengar <ssengar@...ux.microsoft.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        kys@...rosoft.com, haiyangz@...rosoft.com, wei.liu@...nel.org,
        decui@...rosoft.com, daniel.lezcano@...aro.org, tglx@...utronix.de,
        virtualization@...ts.linux-foundation.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-hyperv@...r.kernel.org, mikelley@...rosoft.com,
        ssengar@...rosoft.com
Subject: Re: [PATCH v2 5/6] dt-bindings: hypervisor: Add dt-bindings for VMBus

On Tue, Jan 31, 2023 at 07:54:56PM +0100, Krzysztof Kozlowski wrote:
> On 31/01/2023 19:10, Saurabh Sengar wrote:
> > 
> > Signed-off-by: Saurabh Sengar <ssengar@...ux.microsoft.com>
> 
> > +  - |
> > +    / {
> > +        compatible = "foo";
> > +        model = "foo";
> > +        #address-cells = <0x02>;
> > +        #size-cells = <0x02>;
> 
> Except previous comments (all of them were ignored),

Thank you for your comments, I have tried to address them all in this version
but I may have missed few. I will go and look again all the emails, but if
there is any thing which you can point again and we can start a new dicussion
from here will be very helpful.

I think one concern was related to use of 'reg' or 'ranges', and I 
thought this patch will give clarity that I intend to use 'ranges'
without any child node. Is this acceptable ?


> also:
> Drop entire part. Not related, not correct, not helping and you cannot
> have top level nodes in example.

If I dont use the top level node, the parent address cells are assumed to be 1,
and I get below warning. If there is better way to address this warning, please
suggest I will work on it.

Warning (ranges_format): /example-0/vmbus@...000000:ranges: "ranges" property has invalid length (20 bytes) (parent #address-cells == 1, child #address-cells == 2, #size-cells == 1)

> 
> > +
> > +        vmbus@...000000 {
> > +            #address-cells = <0x02>;
> > +            #size-cells = <0x01>;
> > +            compatible = "msft,vmbus";
> > +            ranges = <0x00 0x00 0x0f 0xf0000000 0x10000000>;
> > +        };
> > +    };
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > index 1f7a519a936f..ab74ea97535f 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > @@ -876,6 +876,8 @@ patternProperties:
> >      deprecated: true
> >    "^mscc,.*":
> >      description: Microsemi Corporation
> > +  "^msft,.*":
> > +    description: Microsoft Corporation
> 
> Don't duplicate vendor prefixes. Drop and use correct prefix.

Sure, will fix this.

Regards,
Saurabh

> 
> Best regards,
> Krzysztof