linux-kernel - Re: [PATCH] ASoC: dt-bindings: Drop broken irondevice,sma1303 binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1bcd61d6-810f-1239-1b6e-367e0fe87370@linaro.org>
Date:   Wed, 1 Feb 2023 14:13:46 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Kiseok Jo <kiseok.jo@...ndevice.com>
Subject: Re: [PATCH] ASoC: dt-bindings: Drop broken irondevice,sma1303 binding

On 01/02/2023 14:10, Krzysztof Kozlowski wrote:
> This reverts entire SMA1303 submission:
> 
> 1. commit 1c24d12b68fa ("ASoC: dt-bindings: irondevice,sma1303.yaml: Fix about breaking the checks")
> 2. commit dcf6d2ef0e82 ("ASoC: Modified the schema binding and added the vendor prefixes.")
> 3. commit 5b28c049ff53 ("ASoC: SMA1303: Fix spelling mistake "Invald" -> "Invalid"")
> 4. commit 68cd394efd0f ("ASoC: The Iron Device SMA1303 is a boosted Class-D audio amplifier.")
> 
> Because the binding:
> 1. Was never tested,
> 2. Was never sent to Devicetree maintainers,
> 3. Is entirely broken and wrong, so it would have to be almost rewritten
>    from scratch,
> 4. It does not match the driver, IOW, the binding is fake.
> 
> We cannot accept drivers with broken bindings and make it an ABI.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---

I understand that in general we tend to fix, not just to revert. But the
poor quality of this binding and the next patch, which was suppose to
fix it, plus complete lack of testing, means I do not believe the author
will send correct binding.

More over, fixing binding might require dropping incorrect properties,
thus changing the driver. I am not willing to do that, I doubt that
anyone has the time for it.

It's the job of submitter to work on it.

Best regards,
Krzysztof