linux-kernel - Re: [PATCH v4 2/5] drivers: regulator: Add ADI MAX77541/MAX77540 Regulator Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y9p3dIj+ix0A7SpR@sirena.org.uk>
Date:   Wed, 1 Feb 2023 14:30:12 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Okan Sahin <okan.sahin@...log.com>
Cc:     Lee Jones <lee@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        William Breathitt Gray <william.gray@...aro.org>,
        ChiYuan Huang <cy_huang@...htek.com>,
        Marcus Folkesson <marcus.folkesson@...il.com>,
        Caleb Connolly <caleb.connolly@...aro.org>,
        Ramona Bolboaca <ramona.bolboaca@...log.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org
Subject: Re: [PATCH v4 2/5] drivers: regulator: Add ADI MAX77541/MAX77540
 Regulator Support

On Wed, Feb 01, 2023 at 01:35:15PM +0300, Okan Sahin wrote:
> Regulator driver for both MAX77541 and MAX77540.
> The MAX77541 is a high-efficiency step-down converter
> with two 3A switching phases for single-cell Li+ battery
> and 5VDC systems.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

> +	if (max77541->chip->id == MAX77540)
> +		desc = max77540_regulators_desc;
> +	else if (max77541->chip->id == MAX77541)
> +		desc = max77541_regulators_desc;
> +	else
> +		return -EINVAL;

Write this as a switch statement for extensibility.

Otherwise this looks good.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)