linux-kernel - Re: [PATCH 05/12] cifs: Add a function to Hash the contents of an iterator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <312908.1675262203@warthog.procyon.org.uk>
Date:   Wed, 01 Feb 2023 14:36:43 +0000
From:   David Howells <dhowells@...hat.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     dhowells@...hat.com, smfrench@...il.com, viro@...iv.linux.org.uk,
        nspmangalore@...il.com, rohiths.msft@...il.com, tom@...pey.com,
        metze@...ba.org, hch@...radead.org, willy@...radead.org,
        jlayton@...nel.org, linux-cifs@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        sfrench@...ba.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH 05/12] cifs: Add a function to Hash the contents of an iterator

Herbert Xu <herbert@...dor.apana.org.au> wrote:

> > Add a function to push the contents of a BVEC-, KVEC- or XARRAY-type
> > iterator into a symmetric hash algorithm.
> 
> There is no such thing as a symmetric hash.  You're using shash
> which stands for synchronous hash.

Sorry, you're right.

> In any case, as I said in the previous review this is abusing the
> shash API.  Please use ahash instead.

It's already abusing the shash API, this doesn't change that, except where it
gets the data from.

I can have a go at conversion to ahash, but that will have to be a separate
patch set as it isn't trivial.  The problem is that the current code just
assumes it can push bits into the hash as it gets them - this is not possible
with ahash.

David