linux-kernel - Re: [PATCH 02/14] ASoC: qcom: SC7280: audioreach: Add sc7280 hardware param fixup callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y9p57qn9+Pig9igE@sirena.org.uk>
Date:   Wed, 1 Feb 2023 14:40:46 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Mohammad Rafi Shaik <quic_mohs@...cinc.com>
Cc:     krzysztof.kozlowski+dt@...aro.org, agross@...nel.org,
        andersson@...nel.org, lgirdwood@...il.com, robh+dt@...nel.org,
        quic_plai@...cinc.com, bgoswami@...cinc.com,
        srinivas.kandagatla@...aro.org, quic_rohkumar@...cinc.com,
        linux-arm-msm@...r.kernel.org, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, swboyd@...omium.org,
        judyhsiao@...omium.org, devicetree@...r.kernel.org,
        konrad.dybcio@...aro.org
Subject: Re: [PATCH 02/14] ASoC: qcom: SC7280: audioreach: Add sc7280
 hardware param fixup callback

On Wed, Feb 01, 2023 at 07:19:35PM +0530, Mohammad Rafi Shaik wrote:

> +#define DEFAULT_SAMPLE_RATE_48K	48000

Why are we bothering with a define here given that the define also
encodes the value and it's only used in once place?

>  	for_each_card_prelinks(card, i, link) {
>  		link->init = sc7280_init;
>  		link->ops = &sc7280_ops;
> +		if (link->no_pcm == 1)
> +			link->be_hw_params_fixup = sc7280_snd_be_hw_params_fixup;

We only set the fixup in the case where there's no PCM but we removed
the constraint in all cases - isn't the constraint needed otherwise?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)