lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Wed, 1 Feb 2023 22:47:07 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sai Prakash Ranjan <quic_saipraka@...cinc.com>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>
Subject: drivers/net/ethernet/adaptec/starfire.c:1831:41: sparse: sparse:
 incorrect type in argument 1 (different base types)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   c0b67534c95c537f7a506a06b98e5e85d72e2b7d
commit: 548927e0312194167f7ee5de47d50c2036088cce arm64: io: Use asm-generic high level MMIO accessors
date:   8 months ago
config: arm64-randconfig-s042-20230201 (https://download.01.org/0day-ci/archive/20230201/202302012215.YjNBuRBU-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=548927e0312194167f7ee5de47d50c2036088cce
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 548927e0312194167f7ee5de47d50c2036088cce
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/net/ethernet/adaptec/ drivers/pci/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

sparse warnings: (new ones prefixed by >>)
   drivers/net/ethernet/adaptec/starfire.c:1515:35: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __wsum [usertype] csum @@     got unsigned short [usertype] @@
   drivers/net/ethernet/adaptec/starfire.c:1515:35: sparse:     expected restricted __wsum [usertype] csum
   drivers/net/ethernet/adaptec/starfire.c:1515:35: sparse:     got unsigned short [usertype]
>> drivers/net/ethernet/adaptec/starfire.c:1831:41: sparse: sparse: incorrect type in argument 1 (different base types) @@     expected unsigned short [usertype] value @@     got restricted __le16 @@
   drivers/net/ethernet/adaptec/starfire.c:1831:41: sparse:     expected unsigned short [usertype] value
   drivers/net/ethernet/adaptec/starfire.c:1831:41: sparse:     got restricted __le16

vim +1831 drivers/net/ethernet/adaptec/starfire.c

5da96be53a16a6 drivers/net/starfire.c                  Jiri Pirko     2011-07-20  1782  
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1783  	if (dev->flags & IFF_PROMISC) {	/* Set promiscuous. */
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1784  		rx_mode |= AcceptAll;
4cd24eaf0c6ee7 drivers/net/starfire.c                  Jiri Pirko     2010-02-08  1785  	} else if ((netdev_mc_count(dev) > multicast_filter_limit) ||
8e95a2026f3b43 drivers/net/starfire.c                  Joe Perches    2009-12-03  1786  		   (dev->flags & IFF_ALLMULTI)) {
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1787  		/* Too many to match, or accept all multicasts. */
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1788  		rx_mode |= AcceptBroadcast|AcceptAllMulticast|PerfectFilter;
4cd24eaf0c6ee7 drivers/net/starfire.c                  Jiri Pirko     2010-02-08  1789  	} else if (netdev_mc_count(dev) <= 14) {
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1790  		/* Use the 16 element perfect filter, skip first two entries. */
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1791  		void __iomem *filter_addr = ioaddr + PerfFilterTable + 2 * 16;
766607570becbd drivers/net/ethernet/adaptec/starfire.c Jakub Kicinski 2021-10-14  1792  		const __be16 *eaddrs;
22bedad3ce112d drivers/net/starfire.c                  Jiri Pirko     2010-04-01  1793  		netdev_for_each_mc_addr(ha, dev) {
22bedad3ce112d drivers/net/starfire.c                  Jiri Pirko     2010-04-01  1794  			eaddrs = (__be16 *) ha->addr;
88b1943bd3e4d2 drivers/net/starfire.c                  Al Viro        2007-08-23  1795  			writew(be16_to_cpu(eaddrs[2]), filter_addr); filter_addr += 4;
88b1943bd3e4d2 drivers/net/starfire.c                  Al Viro        2007-08-23  1796  			writew(be16_to_cpu(eaddrs[1]), filter_addr); filter_addr += 4;
88b1943bd3e4d2 drivers/net/starfire.c                  Al Viro        2007-08-23  1797  			writew(be16_to_cpu(eaddrs[0]), filter_addr); filter_addr += 8;
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1798  		}
766607570becbd drivers/net/ethernet/adaptec/starfire.c Jakub Kicinski 2021-10-14  1799  		eaddrs = (const __be16 *)dev->dev_addr;
5508590c193661 drivers/net/starfire.c                  Jiri Pirko     2010-02-18  1800  		i = netdev_mc_count(dev) + 2;
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1801  		while (i++ < 16) {
88b1943bd3e4d2 drivers/net/starfire.c                  Al Viro        2007-08-23  1802  			writew(be16_to_cpu(eaddrs[0]), filter_addr); filter_addr += 4;
88b1943bd3e4d2 drivers/net/starfire.c                  Al Viro        2007-08-23  1803  			writew(be16_to_cpu(eaddrs[1]), filter_addr); filter_addr += 4;
88b1943bd3e4d2 drivers/net/starfire.c                  Al Viro        2007-08-23  1804  			writew(be16_to_cpu(eaddrs[2]), filter_addr); filter_addr += 8;
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1805  		}
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1806  		rx_mode |= AcceptBroadcast|PerfectFilter;
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1807  	} else {
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1808  		/* Must use a multicast hash table. */
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1809  		void __iomem *filter_addr;
766607570becbd drivers/net/ethernet/adaptec/starfire.c Jakub Kicinski 2021-10-14  1810  		const __be16 *eaddrs;
88b1943bd3e4d2 drivers/net/starfire.c                  Al Viro        2007-08-23  1811  		__le16 mc_filter[32] __attribute__ ((aligned(sizeof(long))));	/* Multicast hash filter */
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1812  
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1813  		memset(mc_filter, 0, sizeof(mc_filter));
22bedad3ce112d drivers/net/starfire.c                  Jiri Pirko     2010-04-01  1814  		netdev_for_each_mc_addr(ha, dev) {
fdecea66687d76 drivers/net/starfire.c                  Jeff Garzik    2005-05-12  1815  			/* The chip uses the upper 9 CRC bits
fdecea66687d76 drivers/net/starfire.c                  Jeff Garzik    2005-05-12  1816  			   as index into the hash table */
22bedad3ce112d drivers/net/starfire.c                  Jiri Pirko     2010-04-01  1817  			int bit_nr = ether_crc_le(ETH_ALEN, ha->addr) >> 23;
88b1943bd3e4d2 drivers/net/starfire.c                  Al Viro        2007-08-23  1818  			__le32 *fptr = (__le32 *) &mc_filter[(bit_nr >> 4) & ~1];
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1819  
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1820  			*fptr |= cpu_to_le32(1 << (bit_nr & 31));
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1821  		}
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1822  		/* Clear the perfect filter list, skip first two entries. */
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1823  		filter_addr = ioaddr + PerfFilterTable + 2 * 16;
766607570becbd drivers/net/ethernet/adaptec/starfire.c Jakub Kicinski 2021-10-14  1824  		eaddrs = (const __be16 *)dev->dev_addr;
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1825  		for (i = 2; i < 16; i++) {
88b1943bd3e4d2 drivers/net/starfire.c                  Al Viro        2007-08-23  1826  			writew(be16_to_cpu(eaddrs[0]), filter_addr); filter_addr += 4;
88b1943bd3e4d2 drivers/net/starfire.c                  Al Viro        2007-08-23  1827  			writew(be16_to_cpu(eaddrs[1]), filter_addr); filter_addr += 4;
88b1943bd3e4d2 drivers/net/starfire.c                  Al Viro        2007-08-23  1828  			writew(be16_to_cpu(eaddrs[2]), filter_addr); filter_addr += 8;
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1829  		}
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1830  		for (filter_addr = ioaddr + HashTable, i = 0; i < 32; filter_addr+= 16, i++)
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16 @1831  			writew(mc_filter[i], filter_addr);
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1832  		rx_mode |= AcceptBroadcast|PerfectFilter|HashFilter;
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1833  	}
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1834  	writel(rx_mode, ioaddr + RxFilterMode);
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1835  }
^1da177e4c3f41 drivers/net/starfire.c                  Linus Torvalds 2005-04-16  1836  

:::::: The code at line 1831 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@...970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@...970.osdl.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ