linux-kernel - Re: [PATCH] riscv: Fix build with CONFIG_CC_OPTIMIZE_FOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y9vkBZknfDOHGZzu@xhacker>
Date:   Fri, 3 Feb 2023 00:25:41 +0800
From:   Jisheng Zhang <jszhang@...nel.org>
To:     Palmer Dabbelt <palmer@...osinc.com>
Cc:     Palmer Dabbelt <palmer@...belt.com>,
        Samuel Holland <samuel@...lland.org>,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Dao Lu <daolu@...osinc.com>, Albert Ou <aou@...s.berkeley.edu>,
        Heiko Stuebner <heiko@...ech.de>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Anup Patel <anup@...infault.org>,
        Atish Patra <atishp@...osinc.com>, Guo Ren <guoren@...nel.org>
Subject: Re: [PATCH] riscv: Fix build with CONFIG_CC_OPTIMIZE_FOR_SIZE=y

On Tue, Jan 31, 2023 at 11:21:10PM -0800, Palmer Dabbelt wrote:
> On Thu, 22 Sep 2022 01:09:58 -0500, Samuel Holland wrote:
> > commit 8eb060e10185 ("arch/riscv: add Zihintpause support") broke
> > building with CONFIG_CC_OPTIMIZE_FOR_SIZE enabled (gcc 11.1.0):
> > 
> >   CC      arch/riscv/kernel/vdso/vgettimeofday.o
> > In file included from <command-line>:
> > ./arch/riscv/include/asm/jump_label.h: In function 'cpu_relax':
> > ././include/linux/compiler_types.h:285:33: warning: 'asm' operand 0 probably does not match constraints
> >   285 | #define asm_volatile_goto(x...) asm goto(x)
> >       |                                 ^~~
> > ./arch/riscv/include/asm/jump_label.h:41:9: note: in expansion of macro 'asm_volatile_goto'
> >    41 |         asm_volatile_goto(
> >       |         ^~~~~~~~~~~~~~~~~
> > ././include/linux/compiler_types.h:285:33: error: impossible constraint in 'asm'
> >   285 | #define asm_volatile_goto(x...) asm goto(x)
> >       |                                 ^~~
> > ./arch/riscv/include/asm/jump_label.h:41:9: note: in expansion of macro 'asm_volatile_goto'
> >    41 |         asm_volatile_goto(
> >       |         ^~~~~~~~~~~~~~~~~
> > make[1]: *** [scripts/Makefile.build:249: arch/riscv/kernel/vdso/vgettimeofday.o] Error 1
> > make: *** [arch/riscv/Makefile:128: vdso_prepare] Error 2
> > 
> > [...]
> 
> Applied, thanks!

Hi Palmer,

I assume the build error is already fixed in v6.1 and can't be reproduced.

Thanks
> 
> [1/1] riscv: Fix build with CONFIG_CC_OPTIMIZE_FOR_SIZE=y
>       https://git.kernel.org/palmer/c/3c349eacc559
> 
> Best regards,
> -- 
> Palmer Dabbelt <palmer@...osinc.com>