linux-kernel - Re: [PATCH] mm/doc: Replace isolate_lru_page with folio_isolate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 02 Feb 2023 11:02:11 -0700
From:   Jonathan Corbet <corbet@....net>
To:     Kuan-Ying Lee <Kuan-Ying.Lee@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>
Cc:     chinwen.chang@...iatek.com, andrew.yang@...iatek.com,
        Kuan-Ying Lee <Kuan-Ying.Lee@...iatek.com>,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-mm@...ck.org
Subject: Re: [PATCH] mm/doc: Replace isolate_lru_page with folio_isolate_lru

Kuan-Ying Lee <Kuan-Ying.Lee@...iatek.com> writes:

> Since we introduce folio, replace isolate_lru_page() with
> folio_isolate_lru().
>
> Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@...iatek.com>
> ---
>  Documentation/mm/page_migration.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

This seems like a good patch to copy to linux-mm - done now.

The patch perhaps is a closer match to what's in linux-next, but it
seems that, if we're going to update this document, we should reflect
the use folios throughout?

Thanks,

jon

> diff --git a/Documentation/mm/page_migration.rst b/Documentation/mm/page_migration.rst
> index 11493bad7112..1f8cc175d770 100644
> --- a/Documentation/mm/page_migration.rst
> +++ b/Documentation/mm/page_migration.rst
> @@ -69,8 +69,8 @@ In kernel use of migrate_pages()
>  
>     Lists of pages to be migrated are generated by scanning over
>     pages and moving them into lists. This is done by
> -   calling isolate_lru_page().
> -   Calling isolate_lru_page() increases the references to the page
> +   calling folio_isolate_lru().
> +   Calling folio_isolate_lru() increases the references to the page
>     so that it cannot vanish while the page migration occurs.
>     It also prevents the swapper or other scans from encountering
>     the page.
> @@ -89,7 +89,7 @@ How migrate_pages() works
>  
>  migrate_pages() does several passes over its list of pages. A page is moved
>  if all references to a page are removable at the time. The page has
> -already been removed from the LRU via isolate_lru_page() and the refcount
> +already been removed from the LRU via folio_isolate_lru() and the refcount
>  is increased so that the page cannot be freed while page migration occurs.
>  
>  Steps:
> -- 
> 2.18.0