[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 2 Feb 2023 10:06:40 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Qingfang DENG <dqfext@...il.com>
Cc: Jesper Dangaard Brouer <hawk@...nel.org>,
Ilias Apalodimas <ilias.apalodimas@...aro.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>,
Lorenzo Bianconi <lorenzo@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>,
John Fastabend <john.fastabend@...il.com>,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: page_pool: use in_softirq() instead
On Wed, 1 Feb 2023 22:01:05 -0800 Jakub Kicinski wrote:
> On Thu, 2 Feb 2023 10:44:17 +0800 Qingfang DENG wrote:
> > From: Qingfang DENG <qingfang.deng@...lower.com.cn>
> >
> > We use BH context only for synchronization, so we don't care if it's
> > actually serving softirq or not.
> >
> > As a side node, in case of threaded NAPI, in_serving_softirq() will
> > return false because it's in process context with BH off, making
> > page_pool_recycle_in_cache() unreachable.
>
> LGTM, but I don't think this qualifies as a fix.
> It's just a missed optimization, right?
Well, nobody seems to have disagreed with me in 12h, so please drop the
Fixes tags and repost against net-next :)
Powered by blists - more mailing lists