linux-kernel - Re: [PATCH RFC] RDMA/rtrs: Don't call kobject_del for srv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Feb 2023 07:59:48 +0000
From:   "lizhijian@...itsu.com" <lizhijian@...itsu.com>
To:     Guoqing Jiang <guoqing.jiang@...ux.dev>,
        "haris.iqbal@...os.com" <haris.iqbal@...os.com>,
        "jinpu.wang@...os.com" <jinpu.wang@...os.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>
CC:     "jgg@...pe.ca" <jgg@...pe.ca>, "leon@...nel.org" <leon@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC] RDMA/rtrs: Don't call kobject_del for srv_path->kobj



On 02/02/2023 15:25, lizhijian@...itsu.com wrote:
> 
> 
> On 02/02/2023 12:09, Guoqing Jiang wrote:
>>>
>>
>> Suppose it also happened during run your script, I guess it might be some
>> racy conditions.
> That's true
> 
> 
>>
>> $ while true;
>> do
>>           echo "sessname=foo path=ip:<ip address> device_path=/dev/nvme0n1" > /sys/devices/virtual/rnbd-client/ctl/map_device
>>           echo "normal" > /sys/block/rnbd0/rnbd/unmap_device
>> done
>>
>>
>> Or does it disappear after revert 6af4609c18b3? If so, we can revert it
>> first.
> 
> Well, everything goes well after i reverted 6af4609c18b3.

6af4609c18b3 seems make senses, so i don't want to revert it entirely if possible.

I have a update for this path like below, i am no longer get problem with this new update.

index c76ba29da1e2..5adba0f754b6 100644
--- a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c
+++ b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c
@@ -312,9 +312,8 @@ void rtrs_srv_destroy_path_files(struct rtrs_srv_path *srv_path)
  
         if (srv_path->kobj.state_in_sysfs) {
                 sysfs_remove_group(&srv_path->kobj, &rtrs_srv_path_attr_group);
-               kobject_del(&srv_path->kobj);
                 kobject_put(&srv_path->kobj);
+               rtrs_srv_destroy_once_sysfs_root_folders(srv_path);
         }
  
-       rtrs_srv_destroy_once_sysfs_root_folders(srv_path);
  }


> 
> Thanks
> Zhijian
>>
>> Thanks,
>> Guoqing