linux-kernel - Re: [PATCH] usb: gadget: udc: do not clear gadget driver.bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y9sRziGWT+WyGRwn@rowland.harvard.edu>
Date:   Wed, 1 Feb 2023 20:28:46 -0500
From:   Alan Stern <stern@...land.harvard.edu>
To:     Aaro Koskinen <aaro.koskinen@....fi>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: udc: do not clear gadget driver.bus

On Thu, Feb 02, 2023 at 12:01:25AM +0200, Aaro Koskinen wrote:
> Before the commit fc274c1e9973 ("USB: gadget: Add a new bus for gadgets")
> gadget driver.bus was unused. For whatever reason, many UDC drivers set
> this field explicitly to NULL in udc_start(). With the newly added gadget
> bus, doing this will crash the driver during the attach.
> 
> The problem was first reported, fixed and tested with OMAP UDC and g_ether.
> Other drivers are changed based on code analysis only.
> 
> Fixes: fc274c1e9973 ("USB: gadget: Add a new bus for gadgets")
> Signed-off-by: Aaro Koskinen <aaro.koskinen@....fi>
> ---

Acked-by: Alan Stern <stern@...land.harvard.edu>