linux-kernel - Re: [PATCH v6 09/13] riscv/kprobe: Search free registers from unused caller-saved ones

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Feb 2023 09:08:38 +0000
From:   Conor Dooley <conor.dooley@...rochip.com>
To:     Chen Guokai <chenguokai17@...ls.ucas.ac.cn>
CC:     <paul.walmsley@...ive.com>, <palmer@...belt.com>,
        <aou@...s.berkeley.edu>, <rostedt@...dmis.org>, <mingo@...hat.com>,
        <sfr@...b.auug.org.au>, <linux-riscv@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <liaochang1@...wei.com>,
        Björn Töpel <bjorn@...nel.org>
Subject: Re: [PATCH v6 09/13] riscv/kprobe: Search free registers from unused
 caller-saved ones

Hey Chen,

Was looking at the insn manipulation code in 4/13 and noticed a minor
nit in this patch in the process.

On Fri, Jan 27, 2023 at 09:05:37PM +0800, Chen Guokai wrote:
> +/*
> + * Register	ABI Name	Saver
> + * x0		zero		--
> + * x1		ra		Caller
> + * x2		sp		Callee
> + * x3		gp		--
> + * x4		tp		--
> + * x5-7 	t0-2		Caller

I know it's just a comment, but this line here has a space before the
first tab that makes nvim unhappy.

Thanks,
Conor.


Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)