linux-kernel - Re: [PATCH net-next v10 1/8] bnxt_en: Add auxiliary driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202302020909.KDHYiYu4-lkp@intel.com>
Date:   Thu, 2 Feb 2023 09:34:56 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ajit Khaparde <ajit.khaparde@...adcom.com>
Cc:     oe-kbuild-all@...ts.linux.dev, andrew.gospodarek@...adcom.com,
        davem@...emloft.net, edumazet@...gle.com, jgg@...pe.ca,
        kuba@...nel.org, leon@...nel.org, linux-kernel@...r.kernel.org,
        linux-rdma@...r.kernel.org, michael.chan@...adcom.com,
        netdev@...r.kernel.org, pabeni@...hat.com,
        selvin.xavier@...adcom.com, gregkh@...uxfoundation.org,
        Leon Romanovsky <leonro@...dia.com>
Subject: Re: [PATCH net-next v10 1/8] bnxt_en: Add auxiliary driver support

Hi Ajit,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Ajit-Khaparde/bnxt_en-Add-auxiliary-driver-support/20230202-044848
patch link:    https://lore.kernel.org/r/20230201204500.19420-2-ajit.khaparde%40broadcom.com
patch subject: [PATCH net-next v10 1/8] bnxt_en: Add auxiliary driver support
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230202/202302020909.KDHYiYu4-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/896eba0b6cd806dd11640cafa66d35f8b483f550
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Ajit-Khaparde/bnxt_en-Add-auxiliary-driver-support/20230202-044848
        git checkout 896eba0b6cd806dd11640cafa66d35f8b483f550
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/ethernet/broadcom/bnxt/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c: In function 'bnxt_aux_dev_release':
>> drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c:483:22: warning: unused variable 'bp' [-Wunused-variable]
     483 |         struct bnxt *bp = netdev_priv(aux_priv->edev->net);
         |                      ^~


vim +/bp +483 drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c

   478	
   479	static void bnxt_aux_dev_release(struct device *dev)
   480	{
   481		struct bnxt_aux_priv *aux_priv =
   482			container_of(dev, struct bnxt_aux_priv, aux_dev.dev);
 > 483		struct bnxt *bp = netdev_priv(aux_priv->edev->net);
   484	
   485		ida_free(&bnxt_aux_dev_ids, aux_priv->id);
   486		kfree(aux_priv->edev);
   487		kfree(aux_priv);
   488	}
   489	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests