linux-kernel - Checkpatch errors that should be downgraded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 02 Feb 2023 11:16:13 +0000
From:   David Howells <dhowells@...hat.com>
To:     Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>
cc:     dhowells@...hat.com, linux-kernel@...r.kernel.org
Subject: Checkpatch errors that should be downgraded

In the trace headers, the following should probably be ignored:

	CHECK: Lines should not end with a '('
	#73: FILE: include/trace/events/rxrpc.h:1947:
	+	    TP_STRUCT__entry(

	CHECK: Lines should not end with a '('
	#80: FILE: include/trace/events/rxrpc.h:1954:
	+	    TP_fast_assign(

as it's standard practice to bump the contents onto the next line for these
two macros.

Also checkpatch is wrong in giving this error:

	ERROR: Macros with complex values should be enclosed in parentheses
	#37: FILE: include/trace/events/rxrpc.h:425:
	+#define rxrpc_sack_traces \
	+	EM(rxrpc_sack_advance,			"ADV")	\
	+	EM(rxrpc_sack_fill,			"FIL")	\
	+	EM(rxrpc_sack_nack,			"NAK")	\
	+	EM(rxrpc_sack_none,			"---")	\
	+	E_(rxrpc_sack_oos,			"OOS")

as the contents, when found in a trace header, are going to be used to
generate a string table and maybe an enum.  It's standard practice, so if it
could be ignored in trace headers or at least downgraded to a warning?

Thanks,
David