[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Thu, 2 Feb 2023 10:00:55 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Carsten Haitzler <Carsten.Haitzler@....com>
Cc: Diederik de Haas <didi.debian@...ow.org>,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Mark Rutland <Mark.Rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>,
Namhyung Kim <namhyung@...nel.org>,
"linux-perf-users@...r.kernel.org" <linux-perf-users@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/2] Script style improvements in lib/coresight.sh
Em Thu, Feb 02, 2023 at 08:38:46AM +0000, Carsten Haitzler escreveu:
> On 2/1/23 21:49, Diederik de Haas wrote:
> > These 2 patches improve the efficiency and quality of the
> > lib/coresight.sh script.
> >
> > The first one uses grep's `-c` parameter to count the results instead of
> > piping it to `wc -l`.
> > The second one replaces the use of backticks (`...`) with $(...) as the
> > former has several potential issues while the latter does not.
> >
> > Diederik de Haas (2):
> > perf test: Replace 'grep | wc -l' with 'grep -c'
> > perf test: Replace legacy `...` with $(...)
> >
> > tools/perf/tests/shell/lib/coresight.sh | 18 +++++++++---------
> > 1 file changed, 9 insertions(+), 9 deletions(-)
> >
> ACK to all of this series.
Thanks, added to the two patches, that I processed yesterday, still in
tmp.perf/core.
- Arnaldo
Powered by blists - more mailing lists