[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <3b81bd45-766b-fe26-d9ec-2097e1fe5a0b@linaro.org>
Date: Fri, 3 Feb 2023 18:54:02 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Maarten Zanders <maarten.zanders@...d.be>,
Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Jacek Anaszewski <jacek.anaszewski@...il.com>
Cc: linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: leds-lp55xx: add ti,charge-pump-mode
On 03/02/2023 16:38, Maarten Zanders wrote:
>
> On 2/2/23 21:13, Krzysztof Kozlowski wrote:
>> + ti,charge-pump-mode:
>>> + description:
>>> + Set the operating mode of the internal charge pump as defined in
>>> + <dt-bindings/leds/leds-lp55xx.h>. Defaults to auto.
>>> + $ref: /schemas/types.yaml#/definitions/uint8
>> This should be then uint32
>
> Why is that? I specifically chose uint8 because other settings for LED
> are also uint8. The implementation is also uint8. I surely hope we'll
> never get to >256 modes for a charge pump.
Because all IDs are unsigned int.
Best regards,
Krzysztof
Powered by blists - more mailing lists