linux-kernel - Re: [PATCH v1] tools/resolve_btfids: Tidy host CFLAGS forcing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230203184125.2ka4cor4pefs3337@skbuf>
Date:   Fri, 3 Feb 2023 20:41:25 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Jiri Olsa <olsajiri@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>
Cc:     Nathan Chancellor <nathan@...nel.org>,
        Ian Rogers <irogers@...gle.com>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <martin.lau@...ux.dev>,
        Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Stanislav Fomichev <sdf@...gle.com>,
        Hao Luo <haoluo@...gle.com>,
        Connor OBrien <connoro@...gle.com>,
        Kumar Kartikeya Dwivedi <memxor@...il.com>,
        bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] tools/resolve_btfids: Tidy host CFLAGS forcing

Hi,

On Thu, Feb 02, 2023 at 12:32:33PM +0100, Jiri Olsa wrote:
> On Wed, Feb 01, 2023 at 02:21:16PM -0700, Nathan Chancellor wrote:
> 
> SNIP
> 
> > > > Should we do this and the hostprogs migration as a follow up? There
> > > > isn't that much use of hostprogs in tools, but I like that your change
> > > > will show HOSTCC rather than CC during compilation. If we use
> > > > hostprogs can we just avoid the overrides altogether?
> > > 
> > > right, I think so.. we can now remove it for the BINARY target and
> > > then for the rest of 'prepare' once they are converted to hostprogs..
> > > not sure how 'hostprogs' will work for library, will need to check
> > > 
> > > I'll try to send the format patch with the fix below tomorrow
> > > 
> > > Nathan, any chance you could test it?
> > 
> > 
> > Sure thing, would you happen to have a single patch file of what I
> > should test? I am a little confused from reading the thread (unless what
> > you want tested has not been sent yet).
> 
> I meant the change below, but I posted the formal patch now:
>   https://lore.kernel.org/bpf/20230202112839.1131892-1-jolsa@kernel.org/T/#u

I've been chasing the links posted by Ian, but now I can't comment on patch
"tools/resolve_btfids: Compile resolve_btfids as host program", because
lkml wasn't CCed, and I'm not subscribed to the bpf ML. So I'm commenting here.

Can someone please apply the patch linked above? Compiling with
CONFIG_DEBUG_INFO_BTF=y is also broken on net-next.

Maintainers can add my

Tested-by: Vladimir Oltean <vladimir.oltean@....com>

on that patch if it helps speed up the process.