linux-kernel - Re: [PATCH] bcache: Remove some unnecessary NULL point check for the return value of __bch_btree_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJedcCxQdqqmKqN9a8-oiot8FKocGNaaCub0r+aE4ndj24L0Yw@mail.gmail.com>
Date:   Fri, 3 Feb 2023 10:47:55 +0800
From:   Zheng Hacker <hackerzheng666@...il.com>
To:     Coly Li <colyli@...e.de>
Cc:     Zheng Wang <zyytlz.wz@....com>, stable@...r.kernel.org,
        Kent Overstreet <kent.overstreet@...il.com>,
        linux-bcache@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        alex000young@...il.com
Subject: Re: [PATCH] bcache: Remove some unnecessary NULL point check for the
 return value of __bch_btree_node_alloc-related pointer

Coly Li <colyli@...e.de> 于2023年2月3日周五 10:46写道：
>
>
>
> > 2023年2月3日 10:43，Zheng Hacker <hackerzheng666@...il.com> 写道：
> >
> > Hello,
> >
> > After writing the patch, I found there may be more places to replace
> > IS_ERR_OR_NULL to IS_ERR.
> > If the alloc of node will never be NULL, the additional NULL check of
> > nodes after allocation may also
> > be useless. This patch just fixes the check around the alloc. I'm not
> > sure about other places for my
> > limited understanding of the code in bcache.
>
> This was why I suggested you to post an extra cleanup patch like this.
>
> You may just add more changes as you mentioned into this patch and post another updated version.
>

Get it. Will do right now.

Thanks,
Zheng Wang