linux-kernel - Re: [PATCH 3/3] erofs: call erofs_map_dev() inside erofs_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d14321a-2406-df05-0401-699547c1b12d@linux.alibaba.com>
Date:   Fri, 3 Feb 2023 13:55:48 +0800
From:   Jingbo Xu <jefflexu@...ux.alibaba.com>
To:     Gao Xiang <hsiangkao@...ux.alibaba.com>, xiang@...nel.org,
        chao@...nel.org, linux-erofs@...ts.ozlabs.org, huyue2@...lpad.com
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] erofs: call erofs_map_dev() inside erofs_map_blocks()



On 2/3/23 1:52 PM, Gao Xiang wrote:
> 
> 
> On 2023/2/3 11:53, Jingbo Xu wrote:
>> For now erofs_map_blocks() is always followed by erofs_map_dev().
>> Make erofs_map_dev() called inside erofs_map_blocks() to reduce code
>> duplication.
> 
> Could we just integrate mdev into struct erofs_map_blocks?

Okay I will give it a try.


> 
> BTW, I still think erofs_map_dev() is useful since it can handle
> non-inode IO requests, so let's keep this rather than mergeing all
> code into erofs_map_blocks()

Yeah erofs_map_dev() is kept as a separated function API.


-- 
Thanks,
Jingbo