linux-kernel - Re: [PATCH] kernel/fail_function: fix memory leak with using debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d2da7780-a816-3c08-3f82-7af1710532c5@huawei.com>
Date:   Fri, 3 Feb 2023 16:12:03 +0800
From:   Yang Yingliang <yangyingliang@...wei.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-kernel@...r.kernel.org>
CC:     Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] kernel/fail_function: fix memory leak with using
 debugfs_lookup()


On 2023/2/2 23:16, Greg Kroah-Hartman wrote:
> When calling debugfs_lookup() the result must have dput() called on it,
> otherwise the memory will leak over time.  To make things simpler, just
> call debugfs_lookup_and_remove() instead which handles all of the logic
> at once.
>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Yang Yingliang <yangyingliang@...wei.com>
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Reviewed-by: Yang Yingliang <yangyingliang@...wei.com>