[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <EA8F3DCB-793D-41BC-AD02-51677D86FEF8@gmail.com>
Date: Fri, 3 Feb 2023 13:41:46 +0400
From: Christian Hewitt <christianshewitt@...il.com>
To: Christian Hewitt <christianshewitt@...il.com>
Cc: Sean Young <sean@...s.org>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
devicetree@...r.kernel.org,
Emanuel Strobel <emanuel.strobel@...oo.com>
Subject: Re: [PATCH v2 0/2] media: rc: add keymap and bindings for Dreambox
remotes
> On 3 Feb 2023, at 1:34 pm, Christian Hewitt <christianshewitt@...il.com> wrote:
>
> This series adds bindings and common keymap for the Dreambox RC10/RC0
> and RC20/RC-BT remote devices.
>
> Changes since v1:
> - Split bindings and keymap into separate patches
> - Revise keymap description to clarify non-IR keys and mappings
> - Revise tagging and key ordering in the keymap
>
> In v1 the RC10/RC0 keymap is incorrectly tagged as RC20/RC-BT and vice
> versa, resulting in some missing //RADIO and //TV keys. Correcting the
> tagging then reordering the keys to match physical layouts [0] and [1]
> results in no missing keys. The keymaps worked, but I've gotten things
> confused when translating from Emanuel's original keymap. So apologies
> for the confusion.
[0] https://www.satking.de/receiver--sat-technik/receiver-zubehoer/fernbedienungen/fernbedienung-dreambox-original-rc10-500hd-525hd-7020hd-dm900-dm920
[1] https://www.satking.de/receiver--sat-technik/receiver-zubehoer/fernbedienungen/dreambox-original-ir-fernbedienung-rc20-fuer-alle-dreamboxen
^ missed these references
> Christian Hewitt (1):
> dt-bindings: media: rc: add rc-dreambox binding
>
> Emanuel Strobel (1):
> media: rc: add common keymap for Dreambox RC10/RC0 and RC20/RC-BT
> remotes
>
> .../devicetree/bindings/media/rc.yaml | 1 +
> drivers/media/rc/keymaps/Makefile | 1 +
> drivers/media/rc/keymaps/rc-dreambox.c | 151 ++++++++++++++++++
> include/media/rc-map.h | 1 +
> 4 files changed, 154 insertions(+)
> create mode 100644 drivers/media/rc/keymaps/rc-dreambox.c
>
> --
> 2.34.1
>
Powered by blists - more mailing lists