linux-kernel - Re: [PATCH v2 00/11] fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Feb 2023 12:39:20 +0300
From:   Maxim Kiselev <bigunclemax@...il.com>
To:     Saravana Kannan <saravanak@...gle.com>
Cc:     Sudeep Holla <sudeep.holla@....com>,
        Naresh Kamboju <naresh.kamboju@...aro.org>,
        abel.vesa@...aro.org, alexander.stein@...tq-group.com,
        andriy.shevchenko@...ux.intel.com, brgl@...ev.pl,
        colin.foster@...advantage.com, cristian.marussi@....com,
        devicetree@...r.kernel.org, dianders@...omium.org,
        djrscally@...il.com, dmitry.baryshkov@...aro.org,
        festevam@...il.com, fido_max@...ox.ru, frowand.list@...il.com,
        geert+renesas@...der.be, geert@...ux-m68k.org,
        gregkh@...uxfoundation.org, heikki.krogerus@...ux.intel.com,
        jpb@...nel.org, jstultz@...gle.com, kernel-team@...roid.com,
        kernel@...gutronix.de, lenb@...nel.org, linus.walleij@...aro.org,
        linux-acpi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-gpio@...r.kernel.org, linux-imx@....com,
        linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux@...ck-us.net, lkft@...aro.org, luca.weiss@...rphone.com,
        magnus.damm@...il.com, martin.kepplinger@...i.sm, maz@...nel.org,
        miquel.raynal@...tlin.com, rafael@...nel.org, robh+dt@...nel.org,
        s.hauer@...gutronix.de, sakari.ailus@...ux.intel.com,
        shawnguo@...nel.org, tglx@...utronix.de, tony@...mide.com
Subject: Re: [PATCH v2 00/11] fw_devlink improvements

пт, 3 февр. 2023 г. в 09:07, Saravana Kannan <saravanak@...gle.com>:
>
> On Thu, Feb 2, 2023 at 9:36 AM Maxim Kiselev <bigunclemax@...il.com> wrote:
> >
> > Hi Saravana,
> >
> > > Can you try the patch at the end of this email under these
> > > configurations and tell me which ones fail vs pass? I don't need logs
> >
> > I did these tests and here is the results:
>
> Did you hand edit the In-Reply-To: in the header? Because in the
> thread you are reply to the wrong email, but the context in your email
> seems to be from the right email.
>
> For example, see how your reply isn't under the email you are replying
> to in this thread overview:
> https://lore.kernel.org/lkml/20230127001141.407071-1-saravanak@google.com/#r
>
> > 1. On top of this series - Not works
> > 2. Without this series    - Works
> > 3. On top of the series with the fwnode_dev_initialized() deleted - Not works
> > 4. Without this series, with the fwnode_dev_initialized() deleted  - Works
> >
> > So your nvmem/core.c patch helps only when it is applied without the series.
> > But despite the fact that this helps to avoid getting stuck at probing
> > my ethernet device, there is still regression.
> >
> > When the ethernet module is loaded it takes a lot of time to drop dependency
> > from the nvmem-cell with mac address.
> >
> > Please look at the kernel logs below.
>
> The kernel logs below really aren't that useful for me in their
> current state. See more below.
>
> ---8<---- <snip> --->8----
>
> > P.S. Your nvmem patch definitely helps to avoid a device probe stuck
> > but look like it is not best way to solve a problem which we discussed
> > in the MTD thread.
> >
> > P.P.S. Also I don't know why your nvmem-cell patch doesn't help when it was
> > applied on top of this series. Maybe I missed something.
>
> Yeah, I'm not too sure if the test was done correctly. You also didn't
> answer my question about the dts from my earlier email.
> https://lore.kernel.org/lkml/CAGETcx8FpmbaRm2CCwqt3BRBpgbogwP5gNB+iA5OEtuxWVTNLA@mail.gmail.com/#t
>
> So, can you please retest config 1 with all pr_debug and dev_dbg in
> drivers/core/base.c changed to the _info variants? And then share the
> kernel log from the beginning of boot? Maybe attach it to the email so
> it doesn't get word wrapped by your email client. And please point me
> to the .dts that corresponds to your board. Without that, I can't
> debug much.
>
> Thanks,
> Saravana

> Did you hand edit the In-Reply-To: in the header? Because in the
> thread you are reply to the wrong email, but the context in your email
> seems to be from the right email.

Sorry for that, it seems like I accidently deleted it.

> So, can you please retest config 1 with all pr_debug and dev_dbg in
> drivers/core/base.c changed to the _info variants? And then share the
> kernel log from the beginning of boot? Maybe attach it to the email so
> it doesn't get word wrapped by your email client. And please point me
> to the .dts that corresponds to your board. Without that, I can't
> debug much.

Ok, I retested config 1 with all _debug logs changed to the _info. I
added the kernel log and the dts file to the attachment of this email.

View attachment "test_kern.log" of type "text/x-log" (22393 bytes)

Download attachment "test.dts" of type "audio/vnd.dts" (7897 bytes)