linux-kernel - Re: [PATCH] firmware: qcom_scm: modify qcom_scm_set_download

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c0642b4b-5a36-8d30-017b-5585a124211a@quicinc.com>
Date:   Fri, 3 Feb 2023 15:48:32 +0530
From:   Mukesh Ojha <quic_mojha@...cinc.com>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        <agross@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>
CC:     <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] firmware: qcom_scm: modify qcom_scm_set_download_mode()



On 2/2/2023 4:47 PM, Srinivas Kandagatla wrote:
> 
> 
> On 24/01/2023 12:19, Mukesh Ojha wrote:
>> -static int __qcom_scm_set_dload_mode(struct device *dev, bool enable)
>> +static int __qcom_scm_set_dload_mode(struct device *dev, enum 
>> qcom_download_mode mode)
>>   {
>>       struct qcom_scm_desc desc = {
>>           .svc = QCOM_SCM_SVC_BOOT,
>>           .cmd = QCOM_SCM_BOOT_SET_DLOAD_MODE,
>>           .arginfo = QCOM_SCM_ARGS(2),
>> -        .args[0] = QCOM_SCM_BOOT_SET_DLOAD_MODE,
>> +        .args[0] = mode,
> 
> Is this a bug fix? why are we changing arg[0]?

Thanks.

This is legacy scm call and it is deprecated.
Let's not change this.
I will fix this in v2.

-Mukesh
> 
> --srini
>>           .owner = ARM_SMCCC_OWNER_SIP,
>>       };
>> -    desc.args[1] = enable ? QCOM_SCM_BOOT_SET_DLOAD_MODE : 0;
>> +    desc.args[1] = mode;
>>       return qcom_scm_call_atomic(__scm->dev, &desc, NULL);
>>   }