linux-kernel - Re: [PATCH 4/7] KVM: PPC: Standardize on "int" return types in the powerpc KVM code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CQ8UPZX0BERP.2TFM4914IGJZF@bobo>
Date:   Fri, 03 Feb 2023 20:21:55 +1000
From:   "Nicholas Piggin" <npiggin@...il.com>
To:     "Thomas Huth" <thuth@...hat.com>, <kvm@...r.kernel.org>,
        "Paolo Bonzini" <pbonzini@...hat.com>,
        "Sean Christopherson" <seanjc@...gle.com>
Cc:     "Claudio Imbrenda" <imbrenda@...ux.ibm.com>,
        "Janosch Frank" <frankja@...ux.ibm.com>,
        "Suzuki K Poulose" <suzuki.poulose@....com>,
        "Marc Zyngier" <maz@...nel.org>,
        "David Hildenbrand" <david@...hat.com>,
        <linux-kernel@...r.kernel.org>,
        "Oliver Upton" <oliver.upton@...ux.dev>,
        "Zenghui Yu" <yuzenghui@...wei.com>,
        "James Morse" <james.morse@....com>,
        <kvm-riscv@...ts.infradead.org>, <kvmarm@...ts.linux.dev>,
        "Christian Borntraeger" <borntraeger@...ux.ibm.com>,
        <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [PATCH 4/7] KVM: PPC: Standardize on "int" return types in the
 powerpc KVM code

On Fri Feb 3, 2023 at 7:42 PM AEST, Thomas Huth wrote:
> Most functions that are related to kvm_arch_vm_ioctl() already use
> "int" as return type to pass error values back to the caller. Some
> outlier functions use "long" instead for no good reason (they do not
> really require long values here). Let's standardize on "int" here to
> avoid casting the values back and forth between the two types.
>
> Signed-off-by: Thomas Huth <thuth@...hat.com>

Thanks for the patch. It looks fine to me, it should be okay to
go via Paolo's tree if he's going to take the series.

Reviewed-by: Nicholas Piggin <npiggin@...il.com>

> ---
>  arch/powerpc/include/asm/kvm_ppc.h  | 14 +++++++-------
>  arch/powerpc/kvm/book3s_64_mmu_hv.c | 14 +++++++-------
>  arch/powerpc/kvm/book3s_64_vio.c    |  4 ++--
>  arch/powerpc/kvm/book3s_hv.c        |  6 +++---
>  arch/powerpc/kvm/book3s_pr.c        |  4 ++--
>  5 files changed, 21 insertions(+), 21 deletions(-)