linux-kernel - Re: [PATCH] phy: rockchip-typec: fix tcphy_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 3 Feb 2023 17:13:48 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Neill Kapron <nkapron@...gle.com>
Cc:     Kishon Vijay Abraham I <kishon@...nel.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Chris Zhong <zyw@...k-chips.com>,
        Kever Yang <kever.yang@...k-chips.com>,
        Guenter Roeck <groeck@...omium.org>,
        linux-kernel@...r.kernel.org, kernel-team@...roid.com,
        Kishon Vijay Abraham I <kishon@...com>
Subject: Re: [PATCH] phy: rockchip-typec: fix tcphy_get_mode error case

On 26-01-23, 00:10, Neill Kapron wrote:
> The existing logic in tcphy_get_mode() can cause the phy to be
> incorrectly configured to USB UFP or DisplayPort mode when
> extcon_get_state returns an error code.
> 
> extcon_get_state() can return 0, 1, or a negative error code.
> 
> It is possible to get into the failing state with an extcon driver
> which does not support the extcon connector id specified as the
> second argument to extcon_get_state().
> 
> tcphy_get_mode()
> ->extcon_get_state()
> -->find_cable_index_by_id()
> --->return -EINVAL;

Applied, thanks

-- 
~Vinod