linux-kernel - Re: 回复: [PATCH net-next v5 1/1] net:openvswitch:reduce cpu_used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Y9z2Lk+VvAHgu/4r@nanopsycho>
Date:   Fri, 3 Feb 2023 12:55:26 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     陶 缘 <taoyuan_eddy@...mail.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Pravin B Shelar <pshelar@....org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "dev@...nvswitch.org" <dev@...nvswitch.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: 回复: [PATCH net-next v5 1/1]
 net:openvswitch:reduce cpu_used_mask memory


Fri, Feb 03, 2023 at 10:03:28AM CET, taoyuan_eddy@...mail.com wrote:
>sorry, Jiri, my bad, will hold on before the next submission/hope it is the final one

Don't top-post please. So what is the change comparing to v4?


>
>eddy
>________________________________
>发件人: Jiri Pirko <jiri@...nulli.us>
>发送时间: 2023年2月3日 9:00
>收件人: Eddy Tao <taoyuan_eddy@...mail.com>
>抄送: netdev@...r.kernel.org <netdev@...r.kernel.org>; Pravin B Shelar <pshelar@....org>; David S. Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; dev@...nvswitch.org <dev@...nvswitch.org>; linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>
>主题: Re: [PATCH net-next v5 1/1] net:openvswitch:reduce cpu_used_mask memory
>
>Fri, Feb 03, 2023 at 09:52:56AM CET, taoyuan_eddy@...mail.com wrote:
>>Use actual CPU number instead of hardcoded value to decide the size
>>of 'cpu_used_mask' in 'struct sw_flow'. Below is the reason.
>>
>>'struct cpumask cpu_used_mask' is embedded in struct sw_flow.
>>Its size is hardcoded to CONFIG_NR_CPUS bits, which can be
>>8192 by default, it costs memory and slows down ovs_flow_alloc
>>
>>To address this, redefine cpu_used_mask to pointer
>>append cpumask_size() bytes after 'stat' to hold cpumask
>>
>>cpumask APIs like cpumask_next and cpumask_set_cpu never access
>>bits beyond cpu count, cpumask_size() bytes of memory is enough
>>
>>Signed-off-by: Eddy Tao <taoyuan_eddy@...mail.com>
>
>Eddy, could you please slow down a bit? Why did you send v5 right
>after v4? Could you please always put a changelog to the patch
>submitted to contain info about changes in between the
>submitted version?
>
>Thanks!
>