[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202302032018.WKygXXHK-lkp@intel.com>
Date: Fri, 3 Feb 2023 20:19:33 +0800
From: kernel test robot <lkp@...el.com>
To: Sam Protsenko <semen.protsenko@...aro.org>,
Marek Szyprowski <m.szyprowski@...sung.com>,
Krzysztof Kozlowski <krzk@...nel.org>,
Sylwester Nawrocki <s.nawrocki@...sung.com>,
Chanwoo Choi <cw00.choi@...sung.com>
Cc: oe-kbuild-all@...ts.linux.dev, Tomasz Figa <tomasz.figa@...il.com>,
Alim Akhtar <alim.akhtar@...sung.com>,
Chanho Park <chanho61.park@...sung.com>,
David Virag <virag.david003@...il.com>,
Sumit Semwal <sumit.semwal@...aro.org>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>,
linux-samsung-soc@...r.kernel.org, linux-clk@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/6] clk: samsung: exynos5433: Extract PM support to
common ARM64 layer
Hi Sam,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on krzk/for-next]
[also build test ERROR on linus/master v6.2-rc6]
[cannot apply to next-20230203]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Sam-Protsenko/clk-samsung-Don-t-pass-reg_base-to-samsung_clk_register_pll/20230203-141059
base: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git for-next
patch link: https://lore.kernel.org/r/20230203060924.8257-7-semen.protsenko%40linaro.org
patch subject: [PATCH 6/6] clk: samsung: exynos5433: Extract PM support to common ARM64 layer
config: openrisc-randconfig-r003-20230202 (https://download.01.org/0day-ci/archive/20230203/202302032018.WKygXXHK-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/7fc08f82f3096e6f1c747f00b9d56c029b0b7a0f
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Sam-Protsenko/clk-samsung-Don-t-pass-reg_base-to-samsung_clk_register_pll/20230203-141059
git checkout 7fc08f82f3096e6f1c747f00b9d56c029b0b7a0f
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=openrisc olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=openrisc SHELL=/bin/bash drivers/clk/samsung/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
drivers/clk/samsung/clk-exynos-arm64.c: In function 'exynos_arm64_cmu_prepare_pm':
>> drivers/clk/samsung/clk-exynos-arm64.c:136:17: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration]
136 | kfree(data->clk_save);
| ^~~~~
| vfree
cc1: some warnings being treated as errors
vim +136 drivers/clk/samsung/clk-exynos-arm64.c
114
115 static int __init exynos_arm64_cmu_prepare_pm(struct device *dev,
116 const struct samsung_cmu_info *cmu)
117 {
118 struct exynos_arm64_cmu_data *data = dev_get_drvdata(dev);
119 int i;
120
121 data->clk_save = samsung_clk_alloc_reg_dump(cmu->clk_regs,
122 cmu->nr_clk_regs);
123 if (!data->clk_save)
124 return -ENOMEM;
125
126 data->nr_clk_save = cmu->nr_clk_regs;
127 data->clk_suspend = cmu->suspend_regs;
128 data->nr_clk_suspend = cmu->nr_suspend_regs;
129 data->nr_pclks = of_clk_get_parent_count(dev->of_node);
130 if (!data->nr_pclks)
131 return 0;
132
133 data->pclks = devm_kcalloc(dev, sizeof(struct clk *), data->nr_pclks,
134 GFP_KERNEL);
135 if (!data->pclks) {
> 136 kfree(data->clk_save);
137 return -ENOMEM;
138 }
139
140 for (i = 0; i < data->nr_pclks; i++) {
141 struct clk *clk = of_clk_get(dev->of_node, i);
142
143 if (IS_ERR(clk)) {
144 kfree(data->clk_save);
145 while (--i >= 0)
146 clk_put(data->pclks[i]);
147 return PTR_ERR(clk);
148 }
149 data->pclks[i] = clk;
150 }
151
152 return 0;
153 }
154
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
Powered by blists - more mailing lists